read oracle user and password from configs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +49,12 @@ public void configure(Binder binder) | |||
| public static ConnectionFactory connectionFactory(BaseJdbcConfig config, OracleConfig oracleConfig) | |||
| throws SQLException | |||
| { | |||
| requireNonNull(config, "BaseJdbc config is null"); | |||
There was a problem hiding this comment.
Since this is a new check that is added, was there any scenario earlier where base config would have been null?
elbinpallimalilibm
approved these changes
Jul 5, 2024
lukmanulhakkeem
pushed a commit
that referenced
this pull request
Sep 6, 2024
Edited query.yaml and created cluster.yaml edited the cluster.yml created queuestatement.yaml Add detailed OpenAPI schema for BasicQueryInfo and other updates Update queued_statement.yaml Updated query.yaml and added _full_spec.yaml Split and add missing components (#1) Also: - re-adds full_spec.yaml to gitignore, - Adds execution to generate a single openAPI JSON. The output is a single JSON that can be used with the swagger editor.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5de5f6b...c6a0351. No notifications. |
lukmanulhakkeem
force-pushed
the
oracle-user-pwd
branch
from
ee8c102
to
8646610
Compare
Signed-off-by: lukmanulhakkeem <lukmanul.hakkeem.a@ibm.com>
lukmanulhakkeem
force-pushed
the
oracle-user-pwd
branch
from
b03a6e1
to
c6a0351
Compare
lukmanulhakkeem
force-pushed
the
master
branch
from
5de5f6b
to
0e489de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we are passing username and password in the connection URL in oracle. But it is better to use the existing basejdbc configs for username and password. This PR is to make changes to use username and password configs for oracle.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: