refactor: separate the LSP6 core contract in logic modules #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello ⛽📊 See Gas Benchmark reportThis document contains the gas usage for common interactions and scenarios when using UniversalProfile smart contracts. 🔀
|
execute scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| transfer LYX to an EOA | 55442 |
| transfer LYX to a UP | 57044 |
| transfer tokens (LSP7) to an EOA (no data) | 101696 |
| transfer tokens (LSP7) to a UP (no data) | 261725 |
| transfer a NFT (LSP8) to a EOA (no data) | 165572 |
| transfer a NFT (LSP8) to a UP (no data) | 289469 |
🛃 restricted controller
execute scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
| transfer some LYXes to an EOA - restricted to 1 x allowed address only (TRANSFERVALUE + 1x AllowedCalls) | 62158 |
| transfers some tokens (LSP7) to an EOA - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 114071 |
| transfers some tokens (LSP7) to an other UP - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 274100 |
| transfers a NFT (LSP8) to an EOA - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 177947 |
| transfers a NFT (LSP8) to an other UP - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 301844 |
🗄️ setData scenarios
👑 unrestricted controller
setData scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| updates profile details (LSP3Profile metadata) | 135626 |
| give permissions to a controller (AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:) | 140144 |
| restrict a controller to some specific ERC725Y Data Keys | 140077 |
| restrict a controller to interact only with 3x specific addresses | 140021 |
| remove a controller (its permissions + its address from the AddressPermissions[] array) | 75499 |
| write 5x LSP12 Issued Assets | 230434 |
🛃 restricted controller
setData scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
setData(bytes32,bytes) -> updates 1x data key |
109016 |
setData(bytes32[],bytes[]) -> updates 3x data keys (first x3) |
166976 |
setData(bytes32[],bytes[]) -> updates 3x data keys (middle x3) |
150909 |
setData(bytes32[],bytes[]) -> updates 3x data keys (last x3) |
175942 |
setData(bytes32[],bytes[]) -> updates 2x data keys + add 3x new controllers (including setting the array length + indexes under AddressPermissions[index]) |
265774 |
📝 Notes
- The
executeandsetDatascenarios are executed on a fresh UniversalProfile and LSP6KeyManager smart contracts, deployed as standard contracts (not as proxy behind a base contract implementation).
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
|
Could you try to merge develop, then clone RV internal repo, and run the foundry tests again the new splitted contracts ? |
YamenMerhi
reviewed
Feb 14, 2023
CJ42
requested changes
Feb 14, 2023
contracts/LSP6KeyManager/LSP6LogicModules/LSP6OwnershipLogicModule.sol
Outdated
Show resolved
Hide resolved
|
|
YamenMerhi
approved these changes
Feb 14, 2023
skimaharvey
approved these changes
Feb 14, 2023
CJ42
approved these changes
Feb 14, 2023
Merged
JeneaVranceanu
added a commit
to JeneaVranceanu/lsp-universalprofile-smart-contracts
that referenced
this pull request
Mar 1, 2023
* develop: refactor!: change LSP5/6/10 Array length from `uint256` to `uint128` (lukso-network#482) ci: temporarily disable downloading Android artifacts on github release (lukso-network#483) perf: reduce LSP1Delegate deployment cost by 8,678 gas (lukso-network#485) feat!: Add batchCalls function in LSP0 and LSP9 (lukso-network#476) test: add tests for edge cases with LSP1 returned values (e.g: `LSP1: asset sent is not registered`, ...) (lukso-network#479) refactor!: change `CHANGEPERMISSIONS` to `EDITPERMISSIONS` (lukso-network#481) ci: check deployer balance before deploy + verify contracts (lukso-network#480) ci: move ci scripts in a `ci/` subfolder (lukso-network#478) docs: add extra note about Address lib in CHANGELOG 0.8.1 (lukso-network#477) chore: prepare release 0.8.1 (lukso-network#474) refactor: replace param with literal LSP9 interfaceId (lukso-network#472) refactor: Support Extension for `bytes4(0)` sig in LSP0-LSP9 (lukso-network#473) refactor: separate the LSP6 core contract in logic modules (lukso-network#461) feat: create `LSP0Utils` library with functions to retrieve LSP1 addresses (lukso-network#466) ci: update CI to publish android artifacts + disable temporarily android artifacts build (web3 not working) (lukso-network#469) chore: remove Address library (lukso-network#471) fix: Add typescript transpilation and hook in package.json exports (lukso-network#470) # Conflicts: # .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
LSP6SetDataLogicModule.sol.LSP6ExecuteLogicModule.sol.LSP6OwnershipLogicModule.sol.getPermissionName(...)andrequirePermissions(...)to theLSP6Utils.solfor re-usability in modules and core contract.Side notes:
requirePermissions(...)in each module, I moved it toLSP6Utils.sol. This function reverts with custom error if the required permission is not present.