use isinstance() to determine type rather than [] #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. But here we want to check if it is an empty list, not only to check if it is a list. |
|
Thank you for your explanation. I have a better understanding of the purpose of this code. So changing |
Seems OK, but I am not 100% sure. It would be safer to use both. |
lululxvi
reviewed
Jul 12, 2023
use isinstance() to determine type rather than [] improve the way to check if tup[0] is empty list add chack if tup[0] is tensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1376
Use
isinstance()to determinetup[0]type rather thantup[0]==[]. Whentupis passed in fromself.w.append(array_ops_compat.hstack(wi))indeepxde\data\fpde.py, line 474,tup[0]==[]can cause the following errors:ValueError: operands could not be broadcast together with shapes (172,) (0,)