WebGLAnimation #105
Open
WebGLAnimation #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get updates
…holder classes for `WebGLRenderingContext` & `WebGL2RenderingContext` which will become the wrappers for our native WebGLContext that is part of the native `window` class.
We can skip BoxGeometry and just use BoxBufferGeometry for now.
That was too easy. WebGLRenderer will map from the material to the actual GLSL shader.
…iona tests to check clearing memory
…type automagically.
Updating Animation branch with latest.
|
😃 |
trusktr
commented
Apr 8, 2021
|
|
||
| // functions or properties required for testing | ||
|
|
||
| requestAnimationFrame(animationLoop: WebGLAnimationFrame): void { |
There was a problem hiding this comment.
ASWebGLue in fact now provides WebGLRenderingContext (we could add WebGLRenderingContext at some point, but for now I just want to get things running).
For requestAnimationFrame, see https://github.com/trusktr/ecmassembly.
trusktr
commented
Apr 8, 2021
| * @param gl version 1 of webgl used by most browsers | ||
| * @param gl2 version 2 of webgl which supports additional texture features and custom XR and VR devices | ||
| */ | ||
| setContext(gl: WebGLRenderingContext | null, gl2: WebGL2RenderingContext | null): void { |
|
@ZoeDreams Gonna circle back to this and get it in. We will replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.