atomic PR which makes Blockquotes and Foonotes easier to read in Dark… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarotero
requested changes
Oct 20, 2024
| [data-theme="dark"] .footnote { | ||
| color: #f1f1f1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Ok, I see that footnotes could be easier to read in dark mode. But these changes should be applied to the Lume's design system (in the .footnotes component: https://github.com/lumeland/ds/blob/main/src/components/footnotes.css).
And the same for blockquotes: https://github.com/lumeland/ds/blob/main/src/components/blockquote.css
And both colors and font sizes must be applied using the existing CSS variables, so people can override them to customize the appearance.
Can you remove the changes in this file? So we can apply them in the lumeland/ds package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from PR #28 .