This repository was archived by the owner on Oct 5, 2021. It is now read-only.
fix issue with refresh_schema thread #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joycelau1
reviewed
Jan 20, 2020
PalSzabolcs
reviewed
Jan 20, 2020
| @@ -61,7 +62,7 @@ def retrieve | |||
| def schema_refresher | |||
| loop do | |||
| refresh_schema | |||
| sleep(SCHEMA_REFRESH_INTERVAL) | |||
| sleep(SCHEMA_REFRESH_INTERVAL.to_i) | |||
There was a problem hiding this comment.
hm, this shouldn't be needed, ruby automatically converts 1.hour to 3600, but i guess there is a reason to this change?
There was a problem hiding this comment.
when value gets from yml, than it is parsed as string
if it gets default value, parsing to int will work too
There was a problem hiding this comment.
yeah, strange that i won't get parsed as an integer, but this should than fix it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#103