Removed rivers and added more complex cases #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul4156
commented
Jul 18, 2017
paul4156
commented
- Rivers style is removed completely
- More complex (multiple line) cases for insert/update are added
* Rivers style is removed completely * More complex (multiple line) cases for insert/update are added
|
We are going to adopt this style, but found it is not consistent. Mainly the indents are mixed with left alignments (2 spaces indent) and rivers (right alignments). It will cause confusions and unnecessary debates. I don't think we can live with rivers as it is not compact (crazy indents in sub sub sub queries) and git friendly (changing all lines after adding a new clause). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.