Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clone derive for trivial_bounds feature #43

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

luxbe
Copy link
Contributor

@luxbe luxbe commented Sep 7, 2023

This PR implements the clone derive, when the inner type derives Clone itself. This is based on the trivial_bounds feature introduced in #33.

The suggestion for this feature came up in issue #26:

Yeah absolutely agree, I've merged the trivial_bounds feature to master. Now we can add some more derived impls that rely on this, Clone would be an easy one to start with.

Originally posted by @lun3x in #26 (comment)

Copy link
Owner

@lun3x lun3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small comment

@lun3x lun3x merged commit 07fb4e3 into lun3x:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants