Skip to content

Commit

Permalink
remove emoji from landing page (pydata#1151)
Browse files Browse the repository at this point in the history
* add fa icons instead of emoji

* remove fix for emojis

* use markup for readme emojis

* use pst-color-primary instead of sd-text-primary

* make our semantic colors available as classes

* try again

---------

Co-authored-by: Daniel McCloy <dan@mccloy.info>
  • Loading branch information
12rambau and drammock authored Feb 7, 2023
1 parent bcc1471 commit 75ee781
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,7 @@ jobs:
cache: "pip"
cache-dependency-path: "pyproject.toml"
- name: Install dependencies
shell: bash
# setting shell to BASH and using PYTHONUTF8 env var makes the editable
# install work on Windows even though there are emoji in our README
run: |
export PYTHONUTF8=1
python -m pip install --upgrade pip wheel setuptools
python -m pip install -e .[doc]
- name: Show installed versions
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

A clean, three-column, Bootstrap-based Sphinx theme by and for the [PyData community](https://pydata.org).

- 📚 Documentation: https://pydata-sphinx-theme.readthedocs.io/en/stable
- 💡 Examples: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples
- 🙌 Contribute: https://pydata-sphinx-theme.readthedocs.io/en/stable/community
- :books: Documentation: https://pydata-sphinx-theme.readthedocs.io/en/stable
- :bulb: Examples: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples
- :raised_hands: Contribute: https://pydata-sphinx-theme.readthedocs.io/en/stable/community

[![Example documentation with this theme](./docs/_static/theme_landing.png)](https://pydata-sphinx-theme.readthedocs.io/en/stable)

Expand Down
12 changes: 6 additions & 6 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@ A clean, Bootstrap-based Sphinx theme by and for [the PyData community](https://
```{gallery-grid}
:grid-columns: 1 2 2 3
- header: "{guilabel}`B` Built with Bootstrap"
- header: "{fab}`bootstrap;pst-color-primary` Built with Bootstrap"
content: "Use Bootstrap classes and functionality in your documentation."
- header: " Responsive Design"
- header: "{fas}`bolt;pst-color-primary` Responsive Design"
content: "Site sections will change behavior and size at different screen sizes."
- header: "🌗 Light / Dark theme"
- header: "{fas}`circle-half-stroke;pst-color-primary` Light / Dark theme"
content: "Users can toggle between light and dark themes interactively."
- header: "🎨 Customizable UI and themes"
- header: "{fas}`palette;pst-color-primary` Customizable UI and themes"
content: "Customize colors and branding with CSS variables, and build custom UIs with [Sphinx Design](user_guide/web-components)."
- header: "{fab}`python` Supports PyData and Jupyter"
- header: "{fab}`python;pst-color-primary` Supports PyData and Jupyter"
content: "CSS and UI support for Jupyter extensions and PyData execution outputs."
link: "examples/pydata.html"
- header: "💡 Example Gallery"
- header: "{fas}`lightbulb;pst-color-primary` Example Gallery"
content: "See our gallery of projects that use this theme."
link: "examples/gallery.html"
```
Expand Down
7 changes: 7 additions & 0 deletions src/pydata_sphinx_theme/assets/styles/variables/_color.scss
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,10 @@ $pst-semantic-colors: (
}
}
}

// assign classes too, for runtime use of theme colors
@each $name, $value in $pst-semantic-colors {
.pst-color-#{$name} {
color: var(--pst-color-#{$name});
}
}

0 comments on commit 75ee781

Please sign in to comment.