Conversation
This also removes a function that was removed in 11.0 (love.window.getPixelScale) and a function that doesn't appear to exist (love.image.newCubeFaces)
There was a problem hiding this comment.
Thanks for the contribution. Not that I use Löve at all myself, but this looks fine.
By the way is there any reason not or projected in the future that we would need to be able to lint against different versions of the API? Or is always targeting the latest one reasonable enough for our purpose?
|
Personally I think it's fine to just target the latest version because people actively developing games probably target the latest version of Löve, but I only started working with Löve just the other week so I might not have enough experience to make the right call. |
|
I think I'll just keep going ahead with this for now and if anybody using Löve decides it is an issue we can help them contribute what it would take to have versioned presets. |
This also removes a function that was removed in 11.0 (love.window.getPixelScale) and a function that doesn't appear to exist (love.image.newCubeFaces)