Declare three windows specific functions as static #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FractalU I've added Windows runs to the CI, can you rebase this PR? Thank you! |
FractalU
force-pushed
the
declare-win-funcs-as-static
branch
from
cde08a1 to
4257f90
Compare
|
@hishamhm Rebased this PR. |
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #168
Declaring these three functions as static ensures that every function which is fully local to
lfs.cand doesn't have a prototype inlfs.his being declared as static. This way, it's sure that there aren't any compiler warnings about missing prototypes, even if the OS is Windows and the compiler is MSVC, gcc or clang.