This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Bump to dotty 0.27.0-RC1 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The biggest change in 0.27.0-RC1 is the change in the extension methods syntax - Because of [#9688](scala/scala3#9688) a temporary fix was applied in calls to `log.xxx` that pass in a single object to log
njlbenn
reviewed
Sep 2, 2020
| @@ -40,7 +40,8 @@ class SudokuProgressTracker private ( | |||
| case NewUpdatesInFlight(updateCount) => | |||
| trackProgress(updatesInFlight + updateCount) | |||
| case msg: SudokuDetailState => | |||
| context.log.error("Received unexpected message in state 'trackProgress': {}", msg) | |||
| // context.log.error("Received unexpected message in state 'trackProgress': {}", msg) | |||
There was a problem hiding this comment.
Maybe we can add an issue in this repo that is a TODO to go back and fix this when the dotty issue (scala/scala3#9688) is addressed? And the issue in our course repo can link the issue in the dotty repo. And then in the code you can add a link to the new issue (otherwise the commented out code isn't really useful by itself)
There was a problem hiding this comment.
Good call!
Will do as otherwise, there's the risk that we forget to revert the workaround when it's no longer needed.
njlbenn
approved these changes
Sep 2, 2020
- Switch to SIB syntax for exercise 3 and later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump from Dotty 0.25.0 to 0.27.0-RC1
syntax
log.xxxthatpass in a single object to
log