Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change functions in file.ts as class #239

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Change functions in file.ts as class #239

merged 2 commits into from
Feb 27, 2018

Conversation

nadongguri
Copy link
Contributor

@nadongguri nadongguri commented Feb 27, 2018 •
edited
Loading

Changed functions in file.ts as class based on rules for modules.

ISSUE=#227

romandev
romandev approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit c261c87 into lunchclass:master Feb 27, 2018
@nadongguri nadongguri deleted the class branch March 8, 2018 04:15
@nadongguri
Copy link
Contributor Author

For testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev approved these changes

@hwanseung hwanseung Awaiting requested review from hwanseung hwanseung is a code owner

@yjaeseok yjaeseok Awaiting requested review from yjaeseok yjaeseok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadongguri @romandev