Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onnx] support more features #141

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[onnx] support more features #141

merged 2 commits into from
Dec 14, 2023

Conversation

luncliff
Copy link
Owner

@luncliff luncliff commented Dec 14, 2023

Changes

Help #136

Bring 2 CMake options into port features

option(ONNX_DISABLE_EXCEPTIONS "Disable exception handling." OFF)
option(ONNX_DISABLE_STATIC_REGISTRATION "Disable static registration for onnx operator schemas." OFF)
  "features": {
    "disable-exception": {
      "description": "Disable exception handling"
    },
    "disable-static-generation": {
      "description": "Disable static registration for onnx operator schemas"
    }
  }

References

In v1.15.0 ...

https://github.com/onnx/onnx/blob/b86cc54efce19530fb953e4b21f57e6b3888534c/CMakeLists.txt#L27-L28
https://github.com/onnx/onnx/blob/b86cc54efce19530fb953e4b21f57e6b3888534c/setup.py#L46

Triplet Support

Major triplets of the repository

Configuration

"vcpkg-configuration.json" changes for the release.

{
    "registries": [
        {
            "kind": "git",
            "repository": "https://github.com/luncliff/vcpkg-registry",
            "packages": [
                {
                  "name": "onnx",
                  "features": [
                    "disable-exception",
                    "disable-static-generation"
                  ]
                }
            ],
            "baseline": "..."
        }
    ]
}

@luncliff luncliff self-assigned this Dec 14, 2023
@luncliff luncliff merged commit 731f580 into main Dec 14, 2023
20 checks passed
@luncliff luncliff deleted the port/onnx-features branch December 14, 2023 23:31
@luncliff luncliff mentioned this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant