Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance callable side effects with optional route argument #158

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

lundberg
Copy link
Owner

@lundberg lundberg commented Aug 17, 2021

Solves #154 and #157

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #158 (3d29794) into master (c1c1e45) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2622      2675   +53     
  Branches       146       149    +3     
=========================================
+ Hits          2622      2675   +53     
Impacted Files Coverage Δ
respx/models.py 100.00% <100.00%> (ø)
tests/test_mock.py 100.00% <100.00%> (ø)
tests/test_router.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c1e45...3d29794. Read the comment docs.

@lundberg lundberg merged commit 5956044 into master Aug 27, 2021
@lundberg lundberg deleted the side-effect-route-arg branch August 27, 2021 13:10
@lundberg
Copy link
Owner Author

Fixed #154
Fixed #157

lundberg added a commit that referenced this pull request Sep 15, 2021
Changed
- Deprecate RESPX MockTransport in favour of HTTPX MockTransport. (#152)

Fixed
- Support HTTPX 1.0.0b0. (#164)
- Allow tuples as params to align with httpx, thanks @shelbylsmith. (#151)
- Fix xfail marked tests. (#153)
- Only publish docs for upstream repo, thanks @hugovk. (#161)

Added
- Add optional route arg to side effects. (#158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants