Fix close method on child writer not closing #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where `child.stdin:close()` on a child process created by `process.create()` did not actually close the `stdin`, this caused processes which read from stdin until EOF to wait indefinitely. On Unix, calling `close` on `async-process::ChildStdin` does not actually close the underyling writer. This is due to it using `async_io::Async` under the hood on Unix, whose `close` implementation just flushes the underlying writer. This has been fixed dropping the `ChildStdin` on close, which will close the underlying writer. An existing test has been updated to catch this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
child.stdin:close()on a child process created byprocess.create()did not actually close thestdin, this caused processes which read from stdin until EOF to wait indefinitely.On Unix, calling
closeonasync-process::ChildStdindoes not actually close the underyling writer. This is due to it usingasync_io::Asyncunder the hood on Unix, whosecloseimplementation just flushes the underlying writer.This has been fixed dropping the
ChildStdinon close, which will close the underlying writer. The internals of the child writer have also been refactored a bit. An existing test has been updated to catch this bug.