fix issues with undelegatio end time (#175)

luniehq · Dec 9, 2019 · 610f855 · 610f855
1 parent 1869328
commit 610f855
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 19 deletions.
diff --git a/lib/reducers/cosmosV2-reducers.js b/lib/reducers/cosmosV2-reducers.js
@@ -93,12 +93,17 @@ function validatorReducer(
 }
 
 function undelegationEndTimeReducer(transaction) {
-  if (
-    transaction.events[1].attributes.find(tx => tx.key === `completion_time`)
-  ) {
-    return transaction.events[1].attributes.filter(
-      tx => tx.key === `completion_time`
-    )[0].value
+  if (transaction.events) {
+    let completionTimeAttribute
+    transaction.events.find(({ attributes }) => {
+      if (attributes) {
+        completionTimeAttribute = attributes.find(
+          tx => tx.key === `completion_time`
+        )
+      }
+      return !!completionTimeAttribute
+    })
+    return completionTimeAttribute.value
   } else {
     return null
   }

diff --git a/lib/reducers/terraV3-reducers.js b/lib/reducers/terraV3-reducers.js
@@ -2,19 +2,24 @@ const cosmosV2Reducers = require('./cosmosV2-reducers')
 
 // Terra has a slightly different structure and needs its own undelegationEndTimeReducer
 function undelegationEndTimeReducer(transaction) {
-  if (transaction.logs[0].events.length > 2) {
-    let endTime
-    const attributes = Object.values(transaction.logs[0].events).map(
-      event => event.attributes
-    )
-    attributes.forEach(attribute =>
-      attribute.map(tx => {
-        if (tx.key === `completion_time`) {
-          endTime = tx.value
-        }
-      })
-    )
-    return endTime ? endTime : null
+  if (transaction.logs) {
+    let completionTimeAttribute
+    transaction.logs.find(({ events }) => {
+      if (events) {
+        events.find(({ attributes }) => {
+          if (attributes) {
+            completionTimeAttribute = attributes.find(
+              tx => tx.key === `completion_time`
+            )
+          }
+          return !!completionTimeAttribute
+        })
+      }
+      return !!completionTimeAttribute
+    })
+    return completionTimeAttribute.value
+  } else {
+    return null
   }
 }