Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Pact test for /stake/delegators/{delegatorAddr}. #1141

Closed
NodeGuy opened this issue Aug 15, 2018 · 3 comments
Closed

Create Pact test for /stake/delegators/{delegatorAddr}. #1141

NodeGuy opened this issue Aug 15, 2018 · 3 comments
Assignees
@NodeGuy
Labels
split 🍌 issues that need to be split into several smaller issues with reduced scope

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 15, 2018

Create a test for the endpoint /stake/delegators/{delegatorAddr} on both the Voyager and SDK sides. Test for both undelegations and redelegations.

This work supports #1133.
@NodeGuy NodeGuy self-assigned this Aug 15, 2018
@NodeGuy NodeGuy mentioned this issue Aug 15, 2018
Closed
@NodeGuy NodeGuy closed this as completed Aug 18, 2018
@NodeGuy NodeGuy reopened this Aug 19, 2018
@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Aug 19, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 20, 2018

On what is this blocked? If this is blocked, let's skip the pact tests and use the existing test structure for #1133

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 20, 2018

I can't write a good test without the help of the SDK team. It has nothing to do with Pact. I'm pair programming with Alessio to get help tomorrow.

@NodeGuy NodeGuy mentioned this issue Aug 20, 2018
Closed
@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Aug 21, 2018
@fedekunze fedekunze added the split 🍌 issues that need to be split into several smaller issues with reduced scope label Aug 28, 2018
@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 28, 2018

Closing in favor of #1193 and #1194.

@NodeGuy NodeGuy closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NodeGuy NodeGuy

Labels
split 🍌 issues that need to be split into several smaller issues with reduced scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NodeGuy @faboweb @fedekunze