Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of /stake/delegators/{delegatorAddr} #1133

Closed
faboweb opened this issue Aug 14, 2018 · 12 comments
Closed

Improve performance of /stake/delegators/{delegatorAddr} #1133

faboweb opened this issue Aug 14, 2018 · 12 comments
Labels
blocked ✋ issues blocked by other implementations/issues bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Aug 14, 2018

UI Version: 0.9.4

Description:

This request takes 45s!
@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss labels Aug 14, 2018
@okwme okwme mentioned this issue Aug 14, 2018
Closed
@faboweb
Copy link
Collaborator Author

faboweb commented Aug 14, 2018

Cris recommended using https://github.com/cosmos/cosmos-sdk/blob/develop/x/stake/keeper/delegation.go#L44
And we need to make copies to query Undelegations and Redelegations that way.

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 14, 2018

Important is we don't loop over all candidates.

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 14, 2018

I presume you mean /stake/delegators/{delegatorAddr}?

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 15, 2018

Yes :)

@faboweb faboweb removed the discuss label Aug 15, 2018
@NodeGuy NodeGuy mentioned this issue Aug 15, 2018
Closed
@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Aug 15, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 15, 2018

Blocked by #1141.

This was referenced Aug 15, 2018
Closed
Closed
@faboweb
Copy link
Collaborator Author

faboweb commented Aug 20, 2018

Why was this removed from the sprint without clarification?

@fedekunze
Copy link
Contributor

@faboweb I'm still working on that. @NodeGuy is blocked on the Pact tests only. Will finish this before the end of the sprint

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 20, 2018

I thought that's what you said you wanted during our call last week—I split the issue into a smaller scope and threw the remainder back into the backlog.

@fedekunze
Copy link
Contributor

Heads up, I'm implementing Sunny's Queriers for this cosmos/cosmos-sdk#1918

@NodeGuy NodeGuy changed the title Improve performance of /delegators/{addr} Improve performance of /stake/delegators/{delegatorAddr} Aug 28, 2018
@NodeGuy NodeGuy mentioned this issue Aug 28, 2018
Closed
@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Aug 28, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 28, 2018

See #1193 about creating a test for this endpoint.

@NodeGuy NodeGuy added this to the staking milestone Aug 30, 2018
@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Sep 4, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Sep 4, 2018

Blocked by a decision of the SDK team on how to handle this.

@NodeGuy NodeGuy mentioned this issue Sep 11, 2018
Closed
4 tasks
@fedekunze fedekunze mentioned this issue Sep 13, 2018
Merged
5 tasks
@fedekunze
Copy link
Contributor

Closed by cosmos/cosmos-sdk#2249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked ✋ issues blocked by other implementations/issues bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Improve performance of /delegators/{addr} luniehq/lunie
3 participants
@NodeGuy @faboweb @fedekunze