WIP: Create Pact test for /stake/delegators/{delegatorAddr} #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeGuy
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
NodeGuy
changed the title
NodeGuy
force-pushed
the
david/staking-pact
branch
2 times, most recently
from
56c1bce to
408b115
Compare
NodeGuy
force-pushed
the
david/staking-pact
branch
2 times, most recently
from
b9d13c8 to
60afe59
Compare
| @@ -492,6 +492,7 @@ func validatorsHandlerFn(cliCtx context.CLIContext, cdc *wire.Codec) http.Handle | |||
| return | |||
| } | |||
|
|
|||
| w.Header().Set("Content-Type", "application/json") | |||
There was a problem hiding this comment.
is this the only non-testing golang change? everything else looks like additional coverage (which is great)
|
Closing for now; we may revisit this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes luniehq/lunie#1133
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: