Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test if errors work in voyager #1192

Closed
faboweb opened this issue Aug 28, 2018 · 7 comments
Closed

test if errors work in voyager #1192

faboweb opened this issue Aug 28, 2018 · 7 comments
Assignees

Comments

@faboweb
Copy link
Collaborator

faboweb commented Aug 28, 2018

As of cosmos/cosmos-sdk#2119 errors returned by the LCD are not longer plain text (with a lot of additional noise) but a JSON object. This should deprecate the need to parse out the error message from this plain text error.
The question is, is there an additional need to adjust Voyagers error parsing (to show the correct error to the user) or do we still need to parse the error from the JSON object.

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 28, 2018

What does this mean?

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 29, 2018

Updated the description.

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 29, 2018

So is this a spike proposal?

@NodeGuy NodeGuy added discuss and removed discuss labels Aug 29, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 29, 2018

How did it end up in Scrumptious with no one assigned?

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 29, 2018

This was a follow up for @fedekunze ticket on the SDK. I forgot the assign someone as it wasn't created in process. I will get to it if I find time.

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 30, 2018

Plan:

  • produce an error in the LCD (like not enough atoms to stake)
  • check if Voyager displays the error user friendly

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 30, 2018

using 0.24.2-fd8c1e52 there is no change visible. I still get the same error structure. Case sent too many tokens I don't have. @fedekunze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants