Parse LCD errors in the lcdClient

[faboweb]

UI Version: 0.9.4

Description:

The LCD delivers errors as some complex string that includes the actual error message. We want to show only the final error to the user. In delegation we are parsing this error already once (#1094). But it would be nice, to parse any error that is delivered in that format and only return that error message to the rest of the system, abstracting the error format away from the Voyager logic.

[faboweb]

Check with SDK team about changing the output.

[fedekunze]

SDK issue: cosmos/cosmos-sdk#2044

[fedekunze]

Closed by cosmos/cosmos-sdk#2119

[NodeGuy]

Why was this reopened?

[fedekunze]

@NodeGuy we need to update the errors coming from the SDK though LCD. I created the method ABCIError() for the sdk.Error struct, but it LCD still returns error.Error(), which is different and not parseable to JSON

[faboweb]

Sorry this was the result of #1192

[fedekunze]

Scope:

• Check that all errors returned by LCD are consistent in format
• Check that all errors are returned as JSON and are parsed correctly
• Check that errors return the appropriate HTTP status code
• Verify that Voyager's notifications show only the msg of the error

[fedekunze]

closed by cosmos/cosmos-sdk#2444

[faboweb]

When I try to undelegate with an existing undelegation, I still get a strange error:

[ERROR] Error while undelegating Steaks: Request failed with status code 500

[NodeGuy]

Should that be a new issue?

[faboweb]

One item of the scope is not meet:

Verify that Voyager's notifications show only the msg of the error