R4R: Standardize REST error responses #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2444 +/- ##
===========================================
- Coverage 57.9% 57.88% -0.02%
===========================================
Files 140 140
Lines 8119 8119
===========================================
- Hits 4701 4700 -1
- Misses 3121 3122 +1
Partials 297 297 |
added 2 commits
October 5, 2018 14:16
jackzampolin
reviewed
Oct 5, 2018
client/keys/add.go
Outdated
| return | ||
| } | ||
| if m.Password == "" { | ||
| msg = "You have to specify a password for the locally stored account." |
There was a problem hiding this comment.
Whats the benefit of storing this in a variable?
|
When do you expect this out of WIP status @fedekunze ? |
added 5 commits
October 9, 2018 10:12
…edekunze/standard-LCD-errors Pull
fedekunze
changed the title
|
Lets try to get this in for 0.25 🤞 |
|
Fix lint please. |
added 2 commits
October 12, 2018 17:53
…edekunze/standard-LCD-errors Pull develop
|
@cwgoes passing all tests now |
cwgoes
reviewed
Oct 15, 2018
melekes
reviewed
Oct 17, 2018
5 tasks
…smos/cosmos-sdk into fedekunze/standard-LCD-errors Pull
|
The current response is the following it should change once we update to newest Tm version: |
|
@cwgoes should be ready for final review |
|
This is great! Would love to get this in for 0.25 @cwgoes |
cwgoes
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2445
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #Reviewed
Files changedin the github PR explorerFor Admin Use: