Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1131 show only err msgs on notifications #1539

Merged
merged 7 commits into from
Nov 8, 2018

Conversation

fedekunze
Copy link
Contributor

Closes #1131

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@fedekunze fedekunze changed the title fedekunze/1131 show only err msgs on notifications WIP: fedekunze/1131 show only err msgs on notifications Nov 8, 2018
@fedekunze fedekunze changed the title WIP: fedekunze/1131 show only err msgs on notifications fedekunze/1131 show only err msgs on notifications Nov 8, 2018
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #1539 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1539      +/-   ##
===========================================
+ Coverage     96.4%   96.41%   +<.01%     
===========================================
  Files           97       97              
  Lines         1810     1811       +1     
  Branches        86       86              
===========================================
+ Hits          1745     1746       +1     
  Misses          55       55              
  Partials        10       10
Impacted Files Coverage Δ
app/src/main/index.js 98.79% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/send.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/blockchain.js 100% <100%> (ø) ⬆️
app/src/renderer/main.js 92.68% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageSend.vue 100% <100%> (ø) ⬆️

@@ -82,14 +82,14 @@ function sleep(ms) {
return new Promise(resolve => setTimeout(resolve, ms))
}

function handleCrash(error) {
function handleCrash(err) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going from a non abbreviated word to an abbreviation feels weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error is a reserved word in some programming languages. Also it makes it easier to search retrieved error responses

@faboweb
Copy link
Collaborator

faboweb commented Nov 8, 2018

Do you think this is an advantage? I think the main problem was showing the correct errors from the LCD and not sth like 500 The server produced and error.

@fedekunze
Copy link
Contributor Author

Do you think this is an advantage? I think the main problem was showing the correct errors from the LCD and not sth like 500 The server produced and error.

The correct errors from the LCD are fixed on the SDK. The missing part was verifying that we didn't append any additional message on top of them

@faboweb faboweb merged commit 7f190d6 into develop Nov 8, 2018
@faboweb faboweb deleted the fedekunze/1131-show-err-msgs-only branch November 8, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse LCD errors in the lcdClient
2 participants