Parsed Err msg #1094
Parsed Err msg #1094
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1094 +/- ##
===========================================
+ Coverage 96.05% 96.06% +0.01%
===========================================
Files 81 81
Lines 1595 1600 +5
Branches 79 80 +1
===========================================
+ Hits 1532 1537 +5
Misses 56 56
Partials 7 7
|
…oyager into fedekunze/1071-err-msgs rebase
| title: "Error While Bonding Atoms", | ||
| body: err.message | ||
| }) | ||
| let errData = err.message.split("\n")[5] |
There was a problem hiding this comment.
This will probably be used more often (like with sending coins). Can we implement this somehow in send.js like changing the error message there?
There was a problem hiding this comment.
I'm trying to figure out which types of errors are encountered while transferring tokens
faboweb
changed the title
…oyager into fedekunze/1071-err-msgs rebase develop
| voting_power: 20000, | ||
| shares: 75000, | ||
| description: "descriptionZ", | ||
| country: "Chile", |
|
i updated the snapshots because the added lines looked like what i expect a revoked validator should look like. there might have also been some errors from the e2e tests yesterday that seem to be circle's fault |
|
@okwme Le'ts take a look into them today |
| @@ -270,7 +270,7 @@ describe("LCD Client Mock", () => { | |||
| it("executes a delegate tx", async () => { | |||
| let stake = await client.queryDelegation( | |||
| lcdClientMock.addresses[0], | |||
| lcdClientMock.validators[2] | |||
| lcdClientMock.validators[1] | |||
There was a problem hiding this comment.
because the validators[2] is the one with status revoked, so all the other tests get the revoked error before anything else happens
| revoked: true | ||
| }) | ||
|
|
||
| let candidates = await node.candidates() |
There was a problem hiding this comment.
candidates are directly exported from lcdClientMock as validators, no need to query them like this. we can leave it like this, though.
| wrapper.findAll("#btn-bond").trigger("click") | ||
| expect(wrapper.vm.$el.querySelector(".tm-form-msg--error")).not.toBeNull() |
There was a problem hiding this comment.
shouldn't there appear an inline error rather then a notification?
| @@ -324,7 +324,9 @@ module.exports = { | |||
| candidate.delegator_shares = ( | |||
| parseInt(candidate.delegator_shares) + amount | |||
| ).toString() | |||
| storeTx("cosmos-sdk/MsgDelegate", tx) | |||
|
|
|||
| // storeTx("cosmos-sdk/MsgDelegate", tx) // do we need this anymore? | |||
There was a problem hiding this comment.
yes, this stores the txs in the txs list to be able to show them in the transaction history
|
i thought it had been removed since it wasn't defined anywhere else but I
think it's another piece missing from your PR
…On Mon, Aug 13, 2018 at 6:52 PM Fabian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/src/renderer/connectors/lcdClientMock.js
<#1094 (comment)>:
> @@ -324,7 +324,9 @@ module.exports = {
candidate.delegator_shares = (
parseInt(candidate.delegator_shares) + amount
).toString()
- storeTx("cosmos-sdk/MsgDelegate", tx)
+
+ // storeTx("cosmos-sdk/MsgDelegate", tx) // do we need this anymore?
yes, this stores the txs in the txs list to be able to show them in the
transaction history
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1094 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA611F9fVUpnfQiiF5dngYtkJRz2Swyxks5uQa7agaJpZM4Vzvy9>
.
|
Closes #1071
Description:
Now errors are well parsed and shows correctly on delegation attempt.
❤️ Thank you!