Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TmPage #1391

Closed
jbibla opened this issue Oct 1, 2018 · 4 comments
Closed

remove TmPage #1391

jbibla opened this issue Oct 1, 2018 · 4 comments
Labels

Comments

@jbibla
Copy link
Collaborator

jbibla commented Oct 1, 2018

TmPage is a small component that doesn't add a lot of value. we no longer have h2 and h3 on each Page - and I think our code will be simpler and cleaner if we just include the necessary components on each page.

.tm-page
  tm-page-header
    h2(v-if="title", slot='title') {{ title }}
    h3(v-if="subtitle", slot='subtitle') {{ subtitle }}
    template(slot='menu-body'): slot(name="menu-body")
    div(slot="menu"): slot(name="menu")
  main.tm-page-main: slot
@fedekunze
Copy link
Contributor

removing TmPage causes #1522 's E2E tests to fail

@fedekunze
Copy link
Contributor

@jbibla so the pages that use TmPage should include the following (without h2, h3) ?

.tm-page
  tm-page-header
    template(slot='menu-body'): slot(name="menu-body")
    div(slot="menu"): slot(name="menu")
  main.tm-page-main: slot

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 26, 2018

well, it depends on the page - but i don't think we need h2, h3, or any slots ... so instead of passing in everything to TmPage just remove the component and add whatever is needed for the page to render the same way... does that make sense?

@jbibla
Copy link
Collaborator Author

jbibla commented Mar 4, 2019

i agree with closing this, but please include a note about why @faboweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants