-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove TmPage #1391
Comments
removing TmPage causes #1522 's E2E tests to fail |
@jbibla so the pages that use TmPage should include the following (without
|
well, it depends on the page - but i don't think we need h2, h3, or any slots ... so instead of passing in everything to |
i agree with closing this, but please include a note about why @faboweb |
TmPage
is a small component that doesn't add a lot of value. we no longer haveh2
andh3
on eachPage
- and I think our code will be simpler and cleaner if we just include the necessary components on each page.The text was updated successfully, but these errors were encountered: