Jordan/1572 scroll bug #1757
Merged
Jordan/1572 scroll bug #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1757 +/- ##
===========================================
+ Coverage 97.7% 97.71% +<.01%
===========================================
Files 102 102
Lines 2096 2102 +6
Branches 93 93
===========================================
+ Hits 2048 2054 +6
Misses 39 39
Partials 9 9
|
faboweb
reviewed
Dec 18, 2018
| @@ -66,6 +67,12 @@ export default { | |||
| // TODO: get min deposit denom from gov params | |||
| ...mapGetters([`proposals`, `filters`, `bondingDenom`, `connected`]) | |||
| }, | |||
| mounted() { | |||
There was a problem hiding this comment.
how about putting this logic into TmPage?
There was a problem hiding this comment.
i know 😞... but i want to get rid of TmPage and also only should run where tabs are present (not on wallet, transactions, or preferences). also, after we bring tendermint-ui into voyager this kind of thing will be easier / more obvious.
There was a problem hiding this comment.
there's an issue for it on #1391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1572
Description:
PageStakingandPageGovernanceso when switching tabs the user is brought to the top of the page.❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer