Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add governance parameters to lcdClient(Mock).js #1564

Closed
fedekunze opened this issue Nov 13, 2018 · 0 comments · Fixed by #1581
Closed

Add governance parameters to lcdClient(Mock).js #1564

fedekunze opened this issue Nov 13, 2018 · 0 comments · Fixed by #1581
Assignees
@fedekunze
Labels
high priority ❗

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Nov 13, 2018 •
edited
Loading

Description:

t's about the be merged on the SDK (cosmos/cosmos-sdk#2576), but we can add the endpoints to the lcdClient(Mock).js to implemet the components right after we update to latest SDK release.

This is necessary bc otherwise we will have to hardcode the values of the parameters (see #1549 (comment))

Swagger file:

https://github.com/cosmos/cosmos-sdk/blob/e206b555f70bae1dfa2a69c2ddb0bb85c8a91a8d/client/lcd/swagger-ui/swagger.yaml#L1457-L1533
@fedekunze fedekunze self-assigned this Nov 13, 2018
This was referenced Nov 13, 2018
Merged
Merged
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
high priority ❗
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fedekunze/1564 query governance params luniehq/lunie
1 participant
@fedekunze