fedekunze/1548 mocked submit deposit #1549
Conversation
…kunze/1548-mock-add-deposit Merge develop
Codecov Report
@@ Coverage Diff @@
## develop #1549 +/- ##
===========================================
+ Coverage 96.52% 96.55% +0.02%
===========================================
Files 99 99
Lines 1872 1915 +43
Branches 92 92
===========================================
+ Hits 1807 1849 +42
- Misses 55 56 +1
Partials 10 10
|
fedekunze
changed the title
| @@ -353,13 +355,13 @@ let state = { | |||
| description: `custom text proposal description`, | |||
| initial_deposit: [ | |||
| { | |||
| denom: `stake`, | |||
| denom: `steak`, | |||
There was a problem hiding this comment.
didn't we want to move towards stake?
There was a problem hiding this comment.
yeah but it's not going to be used until GoS and the denom for governance is still steak
There was a problem hiding this comment.
sure, but this is just the mock implementation and not the real network. does it conflict with settings for the real network?
There was a problem hiding this comment.
not really, but I'd have to add another proposal or refactor it to change that, bc it'll probably break other unit tests that use the mocked proposals. Can I do that on the scope of #1378 ?
There was a problem hiding this comment.
Sure. I just did that PR. Let's see afterwards what breaks. 💥
Closes #1548
Description:
The only test case missing is when the user already has a deposit to the proposal, but not on the same coin denomination, I can add it to the scope of #1553 :
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer