Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steak is now called STAKE #1378

Closed
jbibla opened this issue Sep 28, 2018 · 11 comments · Fixed by #1725
Closed

Steak is now called STAKE #1378

jbibla opened this issue Sep 28, 2018 · 11 comments · Fixed by #1725
Assignees
@faboweb
Labels
blocked ✋ issues blocked by other implementations/issues design-work-needed 🎨 issues that require design work before development high priority ❗

Comments

@jbibla
Copy link
Collaborator

jbibla commented Sep 28, 2018

find and replace steak with stake
@fedekunze fedekunze mentioned this issue Oct 5, 2018
Merged
@fedekunze fedekunze added design-work-needed 🎨 issues that require design work before development staking1 high priority ❗ labels Oct 5, 2018
@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Oct 8, 2018
@faboweb
Copy link
Collaborator

faboweb commented Oct 8, 2018

This is blocked until the staking denom of the network actually says stake.

@fedekunze
Copy link
Contributor

@faboweb I think @jbibla refers to the mocked LCD mostly, since we can get the testnet bonding denom from staking params. So technically it's not blocked

@faboweb
Copy link
Collaborator

faboweb commented Oct 9, 2018

If we change this, the staking denom we manually set will mostly say stake but in the wallet it will still show the actual denom steak.

@jbibla
Copy link
Collaborator Author

jbibla commented Oct 9, 2018

when we release voyager for gaia-9000 - steak should no longer exist. in the mocked LCD and in the UI i suppose.

@jbibla jbibla mentioned this issue Oct 9, 2018
Closed
@faboweb
Copy link
Collaborator

faboweb commented Nov 6, 2018

unblocking this as our next release will not be before gaia-9000

@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Nov 6, 2018
@faboweb faboweb self-assigned this Nov 6, 2018
@fedekunze
Copy link
Contributor

Apparently Gaia-9000 will be using steaks while GoS will use stakes, right @zmanian ?

@faboweb
Copy link
Collaborator

faboweb commented Nov 8, 2018

Can we make it both stakes?

@zmanian
Copy link

zmanian commented Nov 8, 2018

I would need get @greg-szabo to sign the gen-txs again.

I need to figure out how to get the validator bonding txs to be in stake before GoS but I don't want to block 9000 on it.

@greg-szabo
Copy link

I ran the testnet command, apparently it's not reset there?

@zmanian
Copy link

zmanian commented Nov 9, 2018 •
edited
Loading

Depends on cosmos/cosmos-sdk#2752

@fedekunze fedekunze mentioned this issue Nov 13, 2018
Merged
2 tasks
@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Nov 19, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 19, 2018

Doesn't work with SDK version 0.26.1. It still requires the staking denom to be "steak".

@faboweb faboweb changed the title Steak is now called Stake Steak is now called STAKE Dec 11, 2018
@faboweb faboweb mentioned this issue Dec 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
blocked ✋ issues blocked by other implementations/issues design-work-needed 🎨 issues that require design work before development high priority ❗
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fabo/gaia 0.28.0 rc2 luniehq/lunie
5 participants
@zmanian @faboweb @jbibla @greg-szabo @fedekunze