R4R: Don't hardcode bondable denom #2752

alessio · 2018-11-09T17:55:44Z

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez

Changes look reasonable. How come we use the "stake" literal and not stakeTypes.DefaultBondDenom in some places?

codecov · 2018-11-09T18:37:35Z

Codecov Report

Merging #2752 into develop will increase coverage by 0.2%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           develop    #2752     +/-   ##
==========================================
+ Coverage    56.68%   56.88%   +0.2%     
==========================================
  Files          156      155      -1     
  Lines         9788     9753     -35     
==========================================
  Hits          5548     5548             
+ Misses        3862     3827     -35     
  Partials       378      378

jaekwon · 2018-11-12T01:11:36Z

Will merge once replacing "stake" with e.g. "STAKE" in x/stake/types still passes tests.

jaekwon · 2018-11-12T01:46:41Z

I've added a commit w/ more replacements and temporarily replaced DefaultBondDenom with "STAKE", but the tests don't pass yet.

NOTE: Can't merge this for 9001.

…smos-sdk into alessio/default-bondable-denom

alessio · 2018-11-12T12:19:11Z

Fixed now

…

On Mon, 12 Nov 2018, 01:46 Jae Kwon ***@***.*** wrote: I've added a commit w/ more replacements and temporarily replaced DefaultBondDenom with "STAKE", but the tests don't pass yet. NOTE: Can't merge this for 9001. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2752 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7Nw_kXkkn-5fzeEkgo3W_o3px42Yks5uuNMBgaJpZM4YXO8l> .

x/auth/client/txbuilder/txbuilder_test.go

alexanderbez

utACK ☕️

jackzampolin · 2018-11-12T17:38:36Z

The PR as written passes tests for me, but if I go to x/stake/types/params.go and change the DefaultBondDenom to stajake, make test returns some errors:

--- FAIL: TestMsgSubmitProposal (0.00s)
        Error Trace:    msgs_test.go:46
        Error:      	Received unexpected error:
                    	ERROR:
                    	Codespace: 1
                    	Code: 11
                    	Message: "1000stajake,10000foo"
        Test:       	TestMsgSubmitProposal
        Messages:   	test: 9
--- FAIL: TestMsgDeposit (0.00s)
        Error Trace:    msgs_test.go:72
        Error:      	Received unexpected error:
                    	ERROR:
                    	Codespace: 1
                    	Code: 11
                    	Message: "1000stajake,10000foo"
        Test:       	TestMsgDeposit
        Messages:   	test: 4

But the make test_sim_gaia_multi_seed test passes fwiw

alessio · 2018-11-12T17:44:36Z

@jackzampolin try again now

jackzampolin

tACK

cwgoes

TestedACK

@rigelrozanski

* Back to 50 initially bonded * Add query deposits cmds * Update test * Update PENDING.md * Back to on-operation=false, update PENDING.md * Remove unnecessary change, clarify amt in sim_test.go * Cleanup, additional item in PENDING.md * Update PENDING.md Co-Authored-By: alessio <quadrispro@ubuntu.com> * Update client/keys/utils.go Co-Authored-By: alessio <quadrispro@ubuntu.com> * update depositer addr * Address @rigelrozanski comments * Make linter happy * Update PENDING.md * Remove shorthand * Make "multi" const * Store last total power as sdk.Int, not sdk.Dec * Merge PR cosmos#2553: Renamed msg.Name() and msg.Type() to msg.Type() and msg.Route() * Fix stupid mistake * s/number/weight/ * LastValidatorPower is also an Int * Merge PR cosmos#2462: Add swagger-ui for gov, stake and slashing * 'make format' * Move PENDING to CHANGELOG * Linkify changelog * Fix db write perm * Additional cleanup * Remove logs from prior debugging * Merge PR cosmos#2599 from cosmos/jae/dist_refactor * Rename Pool -> DelRewards; PoolCommission -> ValCommision * FeePool.Pool -> FeePool.ValPool * WithdrawalHeight->DelPoolWithdrawalHeight * OnValidatorBeginUnbonding * Caught the bug's tail * Update vi.FeePoolWithdrawalHeight upon bonding * Fix staking slashUnbondingDelegation bug; fixes simulator failure cosmos#9 * Merge PR cosmos#2597: Add distribution accum invariants * PENDING.md => CHANGELOG.md * Manually linkify * Manually fix some links * Docs fixes in progress while running through the release process * More docs fixes * '--voter' is no longer required * Rectify validator setup documentation * Merge PR cosmos#2596: Cmds for validator unbondings and redelegations * Make simulation use a transition matrix for block size This enables simulating periods of high load, and periods of low to no load. (low load because future ops will still terminate in that time frame) * address bez's comments * fix flags in docs, closes cosmos#2530 * Merge PR cosmos#2616: Block redelegations to the same validator * Merge PR cosmos#2623: Speedup simulator by switching to goleveldb Due to requiring app.Commit() at the moment, golevel db is significantly faster than a memdb * fix block offsets in printing simulation block number * Merge PR cosmos#2644: Simulation: Print last block when there is an error There was an off by one error in the log printing function previously * Merge PR cosmos#2642: Add todo diagrams * Various sign command improvements - Exit with error if the user is attempting to sign with a key whose address is not among those who are expected to sign the transaction. - Add --print-signature-only to output only the generated signature. * Check sanity of signatures and report errors when run with --print-sigs * Improve errors reporting * Improve online docs * Refresh PENDING.md * Find better name for --print-signature-only * Fix integration tests * Validate --name * Fix integration tests * s/--print-sigs/--validate-signatures/ * s/--sig-only/--signature-only/ * Docs updated * Update PENDING.md * Rename append, it's go builtin * Set success = false when it fails * Apply suggestions from bez * Nest switches * Fix rebase * Document what --validate-signatures does * perform minor doc and function cleanup * move typedef * Merge PR cosmos#2614: Configurable Bech32 prefix for SDK users * Merge PR cosmos#2643: AppendTag function usage error. append elements do not work * simulation: Make validator choice use validator set This also had to change the default seed, since with the previous one it actually got into a state where there were no validators left bonded, lol. This also changes Unbond msgs from failing with almost 100% probability to now only failing with 33% probability. Thus more of the state machine is getting tested! * Update changelog * Merge PR cosmos#2657: Fix config.js * Merge PR cosmos#2589: Update Vesting Spec * Merge PR cosmos#2656: Revert read-only leveldb database * Revert read-only leveldb database Waiting on a fix for syndtr/goleveldb#240. * Update client/keys/utils.go * Include DNS alt name in certificate Closes: cosmos#2664 * Gaialite signal handling is broken, repair it * Merge PR cosmos#2665: simulation: Remove header from Invariant This got introduced recently, but wasn't actually needed, hence the reversion * Merge PR cosmos#2653: Add benchmark for get and set account * Fix test * Refactor TrapSignal * Fix lint * enforcing @jaekwon mergemaster * added querier redelegation * added validatorDelegations querier endpoint * LCD and CLI * cli fixes * removed redelegation stuff * address other comments * rebased * addressed comments * Make the simulator create the new comission rate sensibly * Update to TM v0.26.0 - Part I (cosmos#2679) * Update to TM v0.26.0 * Bez/tm0.26 update pt 2 redux (cosmos#2684) * Update to TM v0.26.0 * Update TODOs * Proof and verification updates * Fix linting * Fix key path creation * Temporarily fix tendermint revision to make tests pass * Fix merge conflict bug; Update PENDING * New genesis workflow (cosmos#2602) New genesis workflow: * `gaiad init` is now used to generate an empty `genesis.json`. * Genesis accounts need to be populated manually before running `gaiad collect-gentxs`. * This should support starfish too, see cosmos#2615 for more info. * Closes: cosmos#2596 cosmos#2615 * Validate validator address and address against respective account ex ante * Fix local testnet failures * New genesis tests * Run make format * Add --pubkey flag * gaiad collect-gentxs takes no args * Simulation improvements (logging fix, random genesis parameters) (cosmos#2617) * Print out initial update on every block * Randomize simulation parameters * Randomize initial liveness weightings * Randomize genesis parameters * fixed power store invariant * IterateValidatorsBonded -> IterateBondedValidatorsByPower * WriteValidators uses IterateLastValidators rather than IterateBondedValidatorsByPower * fixed democoin interface Closes cosmos#2556 Closes cosmos#2396 Via cosmos#2671: closes cosmos#2669 closes cosmos#2670 closes cosmos#2620 Offshoot issues: cosmos#2618 cosmos#2619 cosmos#2620 cosmos#2661 * Fix simulation bugs; Incorprates cosmos#2676 from Sunny (cosmos#2677) * Fix simulation bugs; Incorprates cosmos#2676 from Sunny * Address review feedback; Update PENDING * 'make format' * Revert "enforcing @jaekwon mergemaster" This reverts commit 15c2093. * Update x/stake/client/rest/query.go Co-Authored-By: sunnya97 <sunnya97@gmail.com> * addressed fede's comment * Switch gov proposal-queues to use iterators (cosmos#2638) * switched gov proposals queue to use iterators * update gov spec * update proposal.Equal * Amino api change * switched proposalID to uint64 * renamed Gov Procedures to Params * s/ActiveProposalQueueProposalKey/KeyActiveProposalQueueProposal/g * numLatestProposals -> Limit * fixed staking invariant breakage because of gov deposits * Send deposits to DepositedCoinsAccAddr or BurnedDepositCoinsAccAddr * Add general merkle absence proof (also for empty substores) (cosmos#2685) * Fix coins.IsLT() impl (cosmos#2686) * Fix coins.IsLT() impl * Fix coin.IsLT() impl * Coins.IsLT -> Coins.IsAllLT etc * Update testnet to use canonical genesis time (cosmos#2692) * Update testnet to use canonical genesis time * Fix linting in genesis test * Do not allow nil values to be set in CacheKVStore (cosmos#2708) * Do not allow nil values to be set in CacheKVStore * Makefile OS compatibility update * Merge PR cosmos#2714: Add commission data to MsgCreateValidator signature bytes * PENDING => CHANGELOG * Linkify changelog * Cleanup bank keeper * whitespacing * rand utile ... * moving stuff around a bit, trying to get rid of types * reorganize more * rename ambig naming of queueOperations * minimizing indentation * fix some duplicate to get passing * Address style comments * Reorganize CLI command structure. Fixes cosmos#2575 * Fix missing flags issue * Address linting issues * Fix gobash CLI testing * Fix typo * Cross-compiling get_tools Makefile added * operations functions * assertAllInvarients changes, Operation reorg * mock tendermint * util cleanup * event stats object, more general cleanup * compiling * pending * Removed comment from Makefile as per bez's request * val comments * Address PR comments * Update cmd/gaia/cmd/gaiacli/main.go Co-Authored-By: jackzampolin <jack.zampolin@gmail.com> * PENDING * Fix state export/import, add to CI (cosmos#2690) * Update slashing import/export * More slashing.WriteGenesis * Add test import/export to CI * Store equality comparison. * Fix validator bond intra-tx counter * Set timeslices for unbonding validators * WriteGenesis => ExportGenesis * Delete validators from unbonding queue when re-bonded * Hook for validator deletion, fix staking genesis tests * Merge 0.26.0 back to develop (cosmos#2718) * PENDING => CHANGELOG * Linkify changelog * Merge PR cosmos#2716: Temporarily disable gaia lite insecure mode * TODO: need to update CHANGELOG w/ import-export PR cosmos#2690 * Update CHANGELOG/PENDING for straggling PR cosmos#2690 * Add small utility to add account to genesis.json after gaiad init * Update CHANGELOG.md * s/WriteGenesisFile/ExportGenesisFile/ * Update PENDING.md * Add --chain-id to testnet command * Address remaining comments from cosmos#2690 * Update PENDING.md * add back in PeriodicInvariant * Linter fix * Fix TimeoutCommit (cosmos#2743) * Fix TimeoutCommit to 5 seconds instead of whatever it was before which was too short. * Gaia-9000: Update to TM 0.26.1-rc2 (cosmos#2753) * Update to tm 0.26.1-rc2 to fix prometheus issue and node disconnect issue. * Gaia-9000: Update to TM 0.26.1-rc3 -- pex SeedMode fix * fix typo I think it might be a spelling mistake * Slight distribution spec cleanup * More cleanup * use defer * Use correct Bech32 prefix for show-address command (cosmos#2746) * Use consensus address bech32 prefix * Update show-address CLI description * Generate random moniker when missing * Update moniker prefix * Require moniker instead of generating a random one * update to tendermint v0.26.1 * Fix test coverage * Correctly set return code * Fix date to be cross platform * Merge PR cosmos#2752: Don't hardcode bondable denom * R4R: Fix unbonding command flow (cosmos#2727) * Fix required flag * Fix redelegation command * Add pending entry * update swagger.yaml * use newQuery...Params * Link to issue * Fix DiffKVStore * Address PR review * Working on stake import/export * Only apply validator set updates on initial genesis * Clarify comment * Fix failing test * add back in CLI command after rebase * Fix CLI tests * update to amino 0.14.1 * pending * R4R: Query Gov Params (cosmos#2576) * gov query params * Merge PR cosmos#2744: Fix Makefile targets dependencies * Fix Makefile targets dependencies * Remove unnecessary build deps from install targets * Create a rule for each tool * Don't dep test_lint on tools * Update docs/spec/distribution/overview.md Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com> * Update docs/spec/distribution/overview.md Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com> * Update docs/spec/distribution/overview.md Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com> * Update overview.md * Documentation Structure Change and Cleanup (cosmos#2808) * Update docs/sdk/clients.md * organize ADR directory like tendermint * docs: move spec-proposals into spec/ * remove lotion, moved to website repo * move getting-started to cosmos-hub, and voyager to website * docs: move lite/ into clients/lite/ * move introduction/ content to website repo * move resources/ content to website repo * mv sdk/clients.md to clients/clients.md * mv validators to cosmos-hub/validators * move deprecated sdk/ content to _attic * sdk/modules.md is duplicate with modules/README.md * consolidate remianing sdk/ files into a single sdk.md * move examples/ to docs/examples/ * mv docs/cosmos-hub to docs/gaia * Add keys/accounts section to localnet docs * Bring back banner (cosmos#2814) * Build docs in CircleCI (cosmos#2810) * error checking the API call * added docs build trigger to circleci job * Update contributing.md with new merge policy (cosmos#2789) * Update contribuiting.md with new merge policy * deleted obsolete file (cosmos#2817)

Alessio Treglia added 2 commits November 9, 2018 17:52

Don't hardcode bondDenom

9f61f35

Fix tetnet command too

bb9be81

alessio added ready-for-review labels Nov 9, 2018

alessio requested review from zmanian, jackzampolin, greg-szabo, mossid, rigelrozanski and cwgoes November 9, 2018 17:55

alessio requested a review from ebuchman as a code owner November 9, 2018 17:55

zmanian mentioned this pull request Nov 9, 2018

Steak is now called STAKE luniehq/lunie#1378

Closed

Alessio Treglia added 3 commits November 9, 2018 18:01

grep -lrw '"steak"' . | grep -v git | xargs sed -i 's/"steak"/"stake"/g'

0d0a220

Avoid hardcoding stake too

551febb

Fix unit tests

d2ee449

alexanderbez reviewed Nov 9, 2018

View reviewed changes

jackzampolin mentioned this pull request Nov 9, 2018

Game of Stakes / gaia-9002 release checklist #2754

Closed

27 tasks

Replace more 'stake' with stakeTypes.DefaultBondDenom

d6e8d1c

Alessio Treglia added 5 commits November 12, 2018 09:04

Don't hardcode "stake"

0ba0875

Merge branch 'alessio/default-bondable-denom' of github.com:cosmos/co…

f752e2f

…smos-sdk into alessio/default-bondable-denom

Replace mode stakes

c992ddc

Sort coins

d94a44a

Sort coins when creating genesis account

236fc8c

alexanderbez reviewed Nov 12, 2018

View reviewed changes

x/auth/client/txbuilder/txbuilder_test.go Outdated Show resolved Hide resolved

Update test

fe6de1b

alexanderbez approved these changes Nov 12, 2018

View reviewed changes

Update PENDING.md

7c01e28

Sort coins

b64b6c2

jackzampolin reviewed Nov 12, 2018

View reviewed changes

cwgoes approved these changes Nov 12, 2018

View reviewed changes

cwgoes merged commit 7082649 into develop Nov 12, 2018

cwgoes deleted the alessio/default-bondable-denom branch November 12, 2018 18:54

abelliumnt mentioned this pull request Dec 5, 2018

R4R: Add unit tests and add valueable PRs from cosmos-sdk irisnet/irishub#758

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R4R: Don't hardcode bondable denom #2752

R4R: Don't hardcode bondable denom #2752

alessio commented Nov 9, 2018 •

edited

Loading

alexanderbez left a comment •

edited

Loading

codecov bot commented Nov 9, 2018 •

edited

Loading

jaekwon commented Nov 12, 2018

jaekwon commented Nov 12, 2018

alessio commented Nov 12, 2018 via email

alexanderbez left a comment

jackzampolin commented Nov 12, 2018 •

edited

Loading

alessio commented Nov 12, 2018

jackzampolin left a comment

cwgoes left a comment

R4R: Don't hardcode bondable denom #2752

R4R: Don't hardcode bondable denom #2752

Conversation

alessio commented Nov 9, 2018 • edited Loading

alexanderbez left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Nov 9, 2018 • edited Loading

Codecov Report

jaekwon commented Nov 12, 2018

jaekwon commented Nov 12, 2018

alessio commented Nov 12, 2018 via email

alexanderbez left a comment

Choose a reason for hiding this comment

jackzampolin commented Nov 12, 2018 • edited Loading

alessio commented Nov 12, 2018

jackzampolin left a comment

Choose a reason for hiding this comment

cwgoes left a comment

Choose a reason for hiding this comment

alessio commented Nov 9, 2018 •

edited

Loading

alexanderbez left a comment •

edited

Loading

codecov bot commented Nov 9, 2018 •

edited

Loading

jackzampolin commented Nov 12, 2018 •

edited

Loading