"gaiad gentx" might need to support additional argument for use in starfish

[zmanian]

gaiad gentx should have arguments that allow setting the following

• delegation amount
• commission rate
• commission max rate
• commission max change rate
• validator public key

This is if we want to implement Starfish as a script that directly calls gaiad gentx instead of a custom binary that support these fields. The support for signed gen-txs in genesis looks good to me.

@alessio

[alexanderbez]

@alessio some of these flags already exist when creating the validator so you can use them.

[alessio]

We have a command to supply all required values: gaiacli tx create-validator. Isn't that enough? Do we want to mirror flags in gentx as well?

[zmanian]

How does the output from gaiacli tx create-validator translate into something that can fed into genesis?

[alessio]

$ gaiacli tx create-validator --from=foo --amount=10steak --pubkey=cosmosvalconspub1zcjduepqe73qqqwq7jer4dcyd36krv5vvg7w825u3l4uevtqt5jjq7n86anqvneklw --commission-max-rate=0.2 --commission-max-change-rate=0.01 --commission-rate=0.1 --chain-id=test --genesis-format > tx.json
$ gaiacli tx sign --offline --name=foo tx.json
Password to sign with 'foo':
{"type":"auth/StdTx","value":{"msg":[{"type":"cosmos-sdk/MsgCreateValidator","value":{"Description":{"moniker":"bizet","identity":"","website":"","details":""},"Commission":{"rate":"0.1000000000","max_rate":"0.2000000000","max_change_rate":"0.0100000000"},"delegator_address":"cosmos173xjcekjq0c6hv99f3wza7543tpj8fth8umduv","validator_address":"cosmosvaloper173xjcekjq0c6hv99f3wza7543tpj8fthzg0csl","pubkey":{"type":"tendermint/PubKeyEd25519","value":"z6IAAcD0sjq3BGx1YbKMYjzjqpyP68yxYF0lIHpn12Y="},"delegation":{"denom":"steak","amount":"10"}}}],"fee":{"amount":[{"denom":"","amount":"0"}],"gas":"200000"},"signatures":[{"pub_key":{"type":"tendermint/PubKeySecp256k1","value":"Ah/o/RXv+krXbkQq0B2g8TNaOV3KZDNKYzDw7fxvqrN7"},"signature":"Z7CoqVMSh43U9afkIuzyiBJbxQPqLCvuogLea4SMzFwlRcrAXOR1YcTuAUtBbKJ+QP8vmvjfnsl5myL/9Xp3/A==","account_number":"0","sequence":"0"}],"memo":""}}

[alessio]

Implemented. Only pubkey is actually extracted from priv_validator.json

[zmanian]

But you don't want to extract pubkey from priv_validator.json. Ideally a validator pubkey is managed by the KMS.

[alessio]

A validator key is Ed25519, support for it has been removed from gaiacli keys altogether.
I'll add the flag - BTW gaiacli keys is my next target when this is resolved.

[zmanian]

I think the default behavior should be to grab a public from priv_validator.jsonbut there should be an easy override via a command line argument to supply another key.

[alessio]

Agreed, will do that

[alessio]

Closed by #2602