display version numbers in builds #1128

jbibla · 2018-08-14T13:01:14Z

…aia version

faboweb · 2018-08-14T13:29:40Z

README.md

+```bash
+open builds/Voyager/Cosmos_Voyager-v0.9.4-Linux/Cosmos\ Voyager.app
+open builds/Voyager/Cosmos_Voyager-v0.9.4-macOS/Cosmos\ Voyager.app
+open builds/Voyager/Cosmos_Voyager-v0.9.4-Windows/Cosmos\ Voyager.app


This is probably not correct for either Window nor Linux ;)

because the file is not called .app on neither Windows nor Linux

ahhh my mistake.

jbibla · 2018-08-14T21:27:21Z

@cosmos/cosmos-ui could use some help with the tests here. not sure how to properly mock electron.remote.app.getVersion() which i think is the issue.

faboweb · 2018-08-15T09:39:02Z

Checkout https://github.com/cosmos/voyager/blob/develop/test/unit/helpers/electron_mock.js where we already mock several other properties of electron.

codecov · 2018-08-15T12:35:31Z

Codecov Report

Merging #1128 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1128      +/-   ##
===========================================
+ Coverage    95.89%   95.89%   +<.01%     
===========================================
  Files           79       79              
  Lines         1584     1585       +1     
  Branches        74       74              
===========================================
+ Hits          1519     1520       +1     
  Misses          58       58              
  Partials         7        7

Impacted Files	Coverage Δ
app/src/main/index.js	`100% <ø> (ø)`	⬆️
...src/renderer/components/common/PagePreferences.vue	`100% <100%> (ø)`	⬆️

faboweb

How to open isn't correct for Windows/Linux

faboweb · 2018-08-15T17:41:37Z

README.md

-Then open the Cosmos Voyager.app:
-
-```bash
-open builds/Voyager/Cosmos_Voyager-v0.9.4-Linux/Cosmos\ Voyager.app


^^ the simple solution

the documentation was out of date. i tried to update it - but i think it's unnecessary.

faboweb · 2018-08-15T17:43:51Z

README.md

-open builds/Cosmos-{platform}-x64/Cosmos.app
+open builds/Voyager/Cosmos_Voyager-v0.9.4-Linux.tar.gz
+open builds/Voyager/Cosmos_Voyager-v0.9.4-macOS.zip
+open builds/Voyager/Cosmos_Voyager-v0.9.4-Windows.zip


Is this tested?

not sure what you mean. if the user is in the correct directory it should open and unzip the files.

open builds/Cosmos-{platform}-x64/Cosmos.app doesn't work for any platform because we put builds in /Voyager now.

is there something i need to be looking out for that i'm not thinking of?

There is no open cmd on Windows/Linux ;)

I added a proposal, let me know what you think.

okwme · 2018-08-16T11:42:32Z

README.md

 ```

 You can specify `--help` to see all options with explanations.

-Run the app.
+Unzip the app version for your OS:


unzip? untar? unpack? also should we include the command?

tar -zxvf yourfile.tar.gz

okwme · 2018-08-16T11:52:46Z

test/unit/helpers/genesis_mock.js

@@ -4,7 +4,7 @@ let testRoot = "./test/unit/tmp/test_root/"

 function mockGenesis() {
  process.env.COSMOS_NETWORK = "./networks/gaiaiaiaiaiaia/"
-  process.env.GAIA_VERSION = "1.2.3-asdf"


do they no longer follow this format?

Jordan preprocesses it on the setter.

jbibla · 2018-08-16T13:59:37Z

README.md

-open builds/Cosmos-{platform}-x64/Cosmos.app
-```
+- Linux: `builds/Voyager/Cosmos_Voyager-v0.9.4-Linux.tar.gz`
+- MacOS: `builds/Voyager/Cosmos_Voyager-v0.9.4-macOS.tar.gz`


but i'm pretty sure this is a .zip @faboweb

sorry my mistake

removed specifics in favour of more general explanation

fedekunze · 2018-08-17T15:24:34Z

README.md

@@ -101,21 +101,17 @@ First [Build Gaia](#build-gaia) and [Download the testnet configurations](#downl
 Here's an example build command:

 ```bash
-yarn run build --commit=HEAD --network=gaia-7001
+yarn run build --commit=HEAD --network=gaia-7005


Should we change it to 8000 ?

fedekunze · 2018-08-17T15:25:17Z

app/src/renderer/components/staking/ChartVotePower.vue

@@ -3,7 +3,7 @@
 </template>

 <script>
-import { mepGetters } from "vuex"
+import { mapGetters } from "vuex"


LOL great catch !

fedekunze

utACK

jbibla added 5 commits August 14, 2018 07:52

update build docs in readme

d6ad65a

add gaia version to process.env

ce57280

use electron to find version from package.json, use process.env for g…

55a60d5

…aia version

cha cha cha changes

61b61ec

trying to fix tests and build with proper versions displaying

17da820

jbibla requested review from faboweb, NodeGuy and nylira as code owners August 14, 2018 13:01

jbibla changed the title ~~display version numbers in builds~~ HELP: display version numbers in builds Aug 14, 2018

fedekunze added the need help label Aug 14, 2018

faboweb reviewed Aug 14, 2018

View reviewed changes

jbibla added 2 commits August 14, 2018 10:57

fixed some tests (still broken though)

114a516

Merge branch 'develop' into jordan/1043-version

ad5fc84

jbibla added 2 commits August 15, 2018 07:36

Merge branch 'develop' into jordan/1043-version

26804c7

fixed tests

9ede933

jbibla changed the title ~~HELP: display version numbers in builds~~ display version numbers in builds Aug 15, 2018

jbibla removed the need help label Aug 15, 2018

faboweb previously requested changes Aug 15, 2018

View reviewed changes

confirmed that builds display versions correctly and fixed readme

6aa477e

faboweb reviewed Aug 15, 2018

View reviewed changes

Update README.md

0413cba

okwme reviewed Aug 16, 2018

View reviewed changes

jbibla commented Aug 16, 2018

View reviewed changes

okwme and others added 2 commits August 16, 2018 16:23

Merge branch 'develop' into jordan/1043-version

5cdf1a7

Merge branch 'develop' into jordan/1043-version

c8c1271

jbibla added 2 commits August 17, 2018 11:10

simpler readme

c3e9301

mepGetters, MEPGETTERS

10aceda

fedekunze reviewed Aug 17, 2018

View reviewed changes

fedekunze approved these changes Aug 17, 2018

View reviewed changes

fedekunze merged commit 7d9fa8b into develop Aug 17, 2018

fedekunze deleted the jordan/1043-version branch August 17, 2018 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

display version numbers in builds #1128

display version numbers in builds #1128

jbibla commented Aug 14, 2018

faboweb Aug 14, 2018

jbibla Aug 14, 2018

faboweb Aug 15, 2018

jbibla Aug 15, 2018

jbibla commented Aug 14, 2018

faboweb commented Aug 15, 2018

codecov bot commented Aug 15, 2018 •

edited

Loading

faboweb left a comment

faboweb Aug 15, 2018

jbibla Aug 15, 2018

faboweb Aug 15, 2018

jbibla Aug 15, 2018

faboweb Aug 16, 2018

faboweb Aug 16, 2018

okwme Aug 16, 2018

okwme Aug 16, 2018

faboweb Aug 16, 2018

jbibla Aug 16, 2018 •

edited

Loading

faboweb Aug 16, 2018

fedekunze Aug 17, 2018

fedekunze Aug 17, 2018 •

edited

Loading

fedekunze left a comment

display version numbers in builds #1128

display version numbers in builds #1128

Conversation

jbibla commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbibla commented Aug 14, 2018

faboweb commented Aug 15, 2018

codecov bot commented Aug 15, 2018 • edited Loading

Codecov Report

faboweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbibla Aug 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedekunze Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 15, 2018 •

edited

Loading

jbibla Aug 16, 2018 •

edited

Loading

fedekunze Aug 17, 2018 •

edited

Loading