-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buh bye blockexplorer #1130
buh bye blockexplorer #1130
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1130 +/- ##
===========================================
- Coverage 96.06% 95.83% -0.23%
===========================================
Files 81 79 -2
Lines 1600 1561 -39
Branches 80 74 -6
===========================================
- Hits 1537 1496 -41
- Misses 56 58 +2
Partials 7 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final outcry that I am not completely agreeing with the way this all went.
@faboweb ! what do you mean? |
e2e broke. Maybe because of the rename of the wallet page link?! the e2e tests look for link names, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added another object with the material icon "exit_to_app" which was used to query for the sign out btn. I now added an ID to the signout btn to not mixup the two.
thank you very much @faboweb |
Closes #1090
Closes #1089
Closes #945
Closes #381