Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buh bye blockexplorer #1130

Merged
merged 14 commits into from
Aug 15, 2018
Merged

buh bye blockexplorer #1130

merged 14 commits into from
Aug 15, 2018

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Aug 14, 2018

Closes #1090
Closes #1089
Closes #945
Closes #381

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1130 into develop will decrease coverage by 0.22%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1130      +/-   ##
===========================================
- Coverage    96.06%   95.83%   -0.23%     
===========================================
  Files           81       79       -2     
  Lines         1600     1561      -39     
  Branches        80       74       -6     
===========================================
- Hits          1537     1496      -41     
- Misses          56       58       +2     
  Partials         7        7
Impacted Files Coverage Δ
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmToolBar.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/PagePreferences.vue 100% <ø> (ø) ⬆️
app/src/renderer/routes.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/AppMenu.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 100% <100%> (ø) ⬆️
.../renderer/components/common/TmConnectedNetwork.vue 100% <100%> (ø) ⬆️
...p/src/renderer/components/common/TmModalSearch.vue 73.33% <0%> (-13.34%) ⬇️

faboweb
faboweb previously approved these changes Aug 14, 2018
Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final outcry that I am not completely agreeing with the way this all went.

@jbibla
Copy link
Collaborator Author

jbibla commented Aug 14, 2018

@faboweb ! what do you mean?

@faboweb
Copy link
Collaborator

faboweb commented Aug 14, 2018

e2e broke. Maybe because of the rename of the wallet page link?! the e2e tests look for link names, I think.

Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added another object with the material icon "exit_to_app" which was used to query for the sign out btn. I now added an ID to the signout btn to not mixup the two.

@faboweb faboweb merged commit de25c66 into develop Aug 15, 2018
@faboweb faboweb deleted the jordan/1090-buh-bye-blockexplorer branch August 15, 2018 09:35
@jbibla
Copy link
Collaborator Author

jbibla commented Aug 15, 2018

thank you very much @faboweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants