Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1473 power not showing #1493

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Oct 25, 2018

Closes #1473

Description:

percent of vote was being calculated on one component instead of closer to the source of the validator object. now, we'll add it to the validator object in the vuex module and it will always be there when we need it 😄

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #1493 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #1493   +/-   ##
========================================
  Coverage    96.93%   96.93%           
========================================
  Files           91       91           
  Lines         1727     1727           
  Branches        77       77           
========================================
  Hits          1674     1674           
  Misses          43       43           
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/delegates.js 100% <100%> (ø) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit a0c9035 into develop Oct 26, 2018
@jbibla jbibla deleted the jordan/1473-power-not-showing branch October 26, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting power not available on "My Validators" page.
2 participants