Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate a little bit about the automatic release process. #1557

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

NodeGuy
Copy link
Contributor

@NodeGuy NodeGuy commented Nov 13, 2018

Closes #1116

Description:

It turns out the release process is already well-documented! This PR adds a little bit of elaboration.


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@NodeGuy NodeGuy force-pushed the david/1116-document-release-process branch from 4edf7fd to 53e510d Compare November 13, 2018 01:21
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #1557 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1557   +/-   ##
========================================
  Coverage    96.52%   96.52%           
========================================
  Files           99       99           
  Lines         1872     1872           
  Branches        92       92           
========================================
  Hits          1807     1807           
  Misses          55       55           
  Partials        10       10

@NodeGuy NodeGuy changed the title Elaborate a little bit about the automatic release process. WIP: Elaborate a little bit about the automatic release process. Nov 13, 2018
@NodeGuy NodeGuy changed the title WIP: Elaborate a little bit about the automatic release process. Elaborate a little bit about the automatic release process. Nov 13, 2018
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also change:

**TODO:** _Work on this process, automate as much as possible_
for
> **Note:** This is a work in progress

and delete the TODO in ### TODO: Signing Builds + add a WIP note ?

@faboweb faboweb merged commit 667fb59 into develop Nov 13, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 13, 2018

argh, to quick to merge. sorry at @fedekunze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants