fedekunze/1568-mocked-submit-proposal #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2018 19:08
Codecov Report
@@ Coverage Diff @@
## develop #1571 +/- ##
===========================================
+ Coverage 96.59% 96.62% +0.02%
===========================================
Files 100 100
Lines 1940 1953 +13
Branches 95 95
===========================================
+ Hits 1874 1887 +13
Misses 56 56
Partials 10 10
|
fedekunze
changed the title
faboweb
reviewed
Nov 14, 2018
| } | ||
|
|
||
| if ( | ||
| proposal_type !== `Text` && |
There was a problem hiding this comment.
A pattern I use sometimes in those cases:
[`Text`, `ParameterChange`, `SoftwareUpgrade`].indexOf(proposal_type) === -1
faboweb
reviewed
Nov 14, 2018
| amount: `5` | ||
| } | ||
| ], | ||
| ...proposal |
faboweb
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1568
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer