Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1590 empty errors #1597

Merged
merged 3 commits into from
Nov 19, 2018
Merged

fedekunze/1590 empty errors #1597

merged 3 commits into from
Nov 19, 2018

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 19, 2018

Closes #1590

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #1597 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1597      +/-   ##
===========================================
+ Coverage    97.42%   97.46%   +0.04%     
===========================================
  Files          100      100              
  Lines         1978     1974       -4     
  Branches        96       93       -3     
===========================================
- Hits          1927     1924       -3     
  Misses          40       40              
+ Partials        11       10       -1
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/send.js 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 100% <100%> (+1.17%) ⬆️

@faboweb
Copy link
Collaborator

faboweb commented Nov 19, 2018

Nice find

@NodeGuy NodeGuy merged commit 0564c2b into develop Nov 19, 2018
@NodeGuy NodeGuy deleted the fedekunze/1590-empty-errors branch November 19, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empy error messages on notifications
3 participants