Jordan/1603 sidebar links #1633
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1633 +/- ##
===========================================
- Coverage 97.63% 97.63% -0.01%
===========================================
Files 101 101
Lines 2031 2029 -2
Branches 90 90
===========================================
- Hits 1983 1981 -2
Misses 37 37
Partials 11 11
|
| @@ -16,7 +12,7 @@ | |||
| | | |||
| router-link(:to="{name: 'Validators'}") the validator list | |||
| | | |||
| | to spread some of your Atoms around. | |||
There was a problem hiding this comment.
lol why did we had spread
| @@ -26,8 +31,7 @@ export default { | |||
| if (this.proposal.proposal_status === `Passed`) | |||
| return { | |||
| button: null, | |||
| message: `This proposal has passed`, | |||
| color: `green` | |||
There was a problem hiding this comment.
I think we should leave it green here
There was a problem hiding this comment.
it's not a little green dot anymore - it's a green checkmark.
if felt the green status dot should be for signalling "voting".
truthfully, i'd like to move status from the little dot into its own column / tab soon.
| @@ -45,7 +49,7 @@ export default { | |||
| return { | |||
| button: `vote`, | |||
| message: `Voting for this proposal is open`, | |||
| color: `blue` | |||
| color: `green` | |||
There was a problem hiding this comment.
and use orange or similar color here
There was a problem hiding this comment.
no green is good for open voting! like a traffic light! GO GO GO!
|
|
totally agree. but trying to stay focussed on our milestones 😄 |
Closes #1603
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer