Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1670 update balance after gov interactions #1727

Merged
merged 6 commits into from
Dec 11, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Dec 10, 2018

Closes #1670

Description:

Voyager is now querying the balance after any tx with a "sender", "depositer", "voter", "proposer" or "recipient" tag with the account of the currently logged in user.

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb requested a review from nylira as a code owner December 10, 2018 15:55
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #1727 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1727      +/-   ##
===========================================
+ Coverage    97.74%   97.74%   +<.01%     
===========================================
  Files          102      102              
  Lines         2083     2084       +1     
  Branches        93       93              
===========================================
+ Hits          2036     2037       +1     
  Misses          38       38              
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/wallet.js 100% <100%> (ø) ⬆️
...pp/src/renderer/components/staking/LiValidator.vue 96% <0%> (ø) ⬆️
.../src/renderer/components/governance/LiProposal.vue 100% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #1727 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1727      +/-   ##
===========================================
+ Coverage    97.74%   97.74%   +<.01%     
===========================================
  Files          102      102              
  Lines         2083     2084       +1     
  Branches        93       93              
===========================================
+ Hits          2036     2037       +1     
  Misses          38       38              
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/wallet.js 100% <100%> (ø) ⬆️
...pp/src/renderer/components/staking/LiValidator.vue 96% <0%> (ø) ⬆️
.../src/renderer/components/governance/LiProposal.vue 100% <0%> (ø) ⬆️

@jbibla jbibla changed the title Fabo/1670 update balance ater gov interactions Fabo/1670 update balance after gov interactions Dec 10, 2018
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 10dc023 into develop Dec 11, 2018
@fedekunze fedekunze deleted the fabo/1670-update-balance-ater-gov-interactions branch December 11, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

balance not updated on fee-only transactions
2 participants