[WIP] Add jsdoc to project #1758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update minor version of vue - examples of documentation - added command `doc` to package.json - explicitely working only on app/src files Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1758 +/- ##
==========================================
- Coverage 97.71% 97.7% -0.01%
==========================================
Files 103 102 -1
Lines 2100 2095 -5
Branches 93 93
==========================================
- Hits 2052 2047 -5
Misses 39 39
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #1758 +/- ##
==========================================
Coverage ? 95.06%
==========================================
Files ? 121
Lines ? 2977
Branches ? 128
==========================================
Hits ? 2830
Misses ? 137
Partials ? 10
|
fedekunze
reviewed
Dec 20, 2018
faboweb
reviewed
Jan 3, 2019
| }, | ||
|
|
||
| { path: `/404`, component: common(`404`) }, | ||
| { path: `*`, component: common(`404`) } | ||
| { path: `/404`, component: require(`./components/common/Page404`).default }, |
faboweb
reviewed
Jan 3, 2019
|
Usually is more convenient to have the doc in the project, to have it more accessible, it can be also be compressed for older versions. We could enforce it on cci of via git hook, as for now the command to update it manually: |
|
OK cool, going with it for now. |
faboweb
previously approved these changes
Jan 3, 2019
|
don't we need to update the |
good point |
|
Let's halt the merge until further discussion |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
|
I closed this one to have a cleaner single commit, just squashed the changes into another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
docto package.jsonCloses #1739
Once we are in a presentable state we may link this in the wiki along with our README
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer