Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1783

Merged
merged 3 commits into from
Jan 3, 2019
Merged

Update README.md #1783

merged 3 commits into from
Jan 3, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 3, 2019

Closes #ISSUE

Description:

❤️ Thank you!

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb requested a review from nylira as a code owner January 3, 2019 11:34
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1783 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1783   +/-   ##
========================================
  Coverage    95.07%   95.07%           
========================================
  Files          122      122           
  Lines         2982     2982           
  Branches       128      128           
========================================
  Hits          2835     2835           
  Misses         137      137           
  Partials        10       10

1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1783 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1783   +/-   ##
========================================
  Coverage    95.07%   95.07%           
========================================
  Files          122      122           
  Lines         2982     2982           
  Branches       128      128           
========================================
  Hits          2835     2835           
  Misses         137      137           
  Partials        10       10

sabau
sabau approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this improves the readibility

@faboweb faboweb merged commit 8eec926 into develop Jan 3, 2019
@faboweb faboweb deleted the fabo/readme-improvement branch January 3, 2019 13:43
@jbibla
Copy link
Collaborator

jbibla commented Jan 3, 2019

was this supposed to close #1694 ?

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 3, 2019

Nop, that was part of splitting billies review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabau sabau sabau approved these changes

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faboweb @jbibla @sabau