-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coreycosman/1776 tm field seed.spec.js update to 100 coverage #1837
Merged
faboweb
merged 5 commits into
luniehq:develop
from
coreycosman:coreycosman/1776-TmFieldSeed.spec.js-update-to-100-coverage
Jan 16, 2019
Merged
Coreycosman/1776 tm field seed.spec.js update to 100 coverage #1837
faboweb
merged 5 commits into
luniehq:develop
from
coreycosman:coreycosman/1776-TmFieldSeed.spec.js-update-to-100-coverage
Jan 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreycosman
requested review from
faboweb,
fedekunze,
jbibla and
sabau
as code owners
January 16, 2019 13:30
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
+ Coverage 94.66% 97.85% +3.19%
===========================================
Files 122 102 -20
Lines 2941 2096 -845
Branches 119 93 -26
===========================================
- Hits 2784 2051 -733
+ Misses 148 37 -111
+ Partials 9 8 -1
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
+ Coverage 94.66% 97.85% +3.19%
===========================================
Files 122 102 -20
Lines 2941 2096 -845
Branches 119 93 -26
===========================================
- Hits 2784 2051 -733
+ Misses 148 37 -111
+ Partials 9 8 -1
|
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
+ Coverage 94.66% 97.85% +3.19%
===========================================
Files 122 102 -20
Lines 2941 2096 -845
Branches 119 93 -26
===========================================
- Hits 2784 2051 -733
+ Misses 148 37 -111
+ Partials 9 8 -1
|
…te-to-100-coverage
Merged, Thx Corey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1774
Description:
this is a clone of 'Coreycosman/1774 tm field seed.spec.js update to 100 coverage' with a git pull, e2e test 42 doesn't pass, all unit tests passing locally, I want to see if it passes the CI
❤️ Thank you!
CHANGELOG.md
with issue # and GitHub usernameFiles changed
in the github PR explorer