Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coreycosman/1776 tm field seed.spec.js update to 100 coverage #1837

Conversation

coreycosman
Copy link
Contributor

@coreycosman coreycosman commented Jan 16, 2019

Closes #1774

Description:

this is a clone of 'Coreycosman/1774 tm field seed.spec.js update to 100 coverage' with a git pull, e2e test 42 doesn't pass, all unit tests passing locally, I want to see if it passes the CI

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1837 into develop will increase coverage by 3.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
+ Coverage    94.66%   97.85%   +3.19%     
===========================================
  Files          122      102      -20     
  Lines         2941     2096     -845     
  Branches       119       93      -26     
===========================================
- Hits          2784     2051     -733     
+ Misses         148       37     -111     
+ Partials         9        8       -1
Impacted Files Coverage Δ
...p/src/renderer/components/common/TmModalSearch.vue 73.33% <0%> (-26.67%) ⬇️
...src/renderer/components/common/TmSessionSignIn.vue 75.86% <0%> (-14.47%) ⬇️
app/src/renderer/components/wallet/PageWallet.vue 91.66% <0%> (-8.34%) ⬇️
app/src/renderer/vuex/modules/themes.js 90.9% <0%> (-2.43%) ⬇️
app/src/renderer/vuex/modules/wallet.js 98.3% <0%> (-1.7%) ⬇️
...derer/components/common/TmSessionAccountDelete.vue 92.85% <0%> (-1.59%) ⬇️
.../renderer/components/common/TmConnectedNetwork.vue 89.47% <0%> (-0.53%) ⬇️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/validators.js 100% <0%> (ø) ⬆️
app/src/renderer/scripts/axiosProxy.js 100% <0%> (ø) ⬆️
... and 90 more

2 similar comments
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1837 into develop will increase coverage by 3.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
+ Coverage    94.66%   97.85%   +3.19%     
===========================================
  Files          122      102      -20     
  Lines         2941     2096     -845     
  Branches       119       93      -26     
===========================================
- Hits          2784     2051     -733     
+ Misses         148       37     -111     
+ Partials         9        8       -1
Impacted Files Coverage Δ
...p/src/renderer/components/common/TmModalSearch.vue 73.33% <0%> (-26.67%) ⬇️
...src/renderer/components/common/TmSessionSignIn.vue 75.86% <0%> (-14.47%) ⬇️
app/src/renderer/components/wallet/PageWallet.vue 91.66% <0%> (-8.34%) ⬇️
app/src/renderer/vuex/modules/themes.js 90.9% <0%> (-2.43%) ⬇️
app/src/renderer/vuex/modules/wallet.js 98.3% <0%> (-1.7%) ⬇️
...derer/components/common/TmSessionAccountDelete.vue 92.85% <0%> (-1.59%) ⬇️
.../renderer/components/common/TmConnectedNetwork.vue 89.47% <0%> (-0.53%) ⬇️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/validators.js 100% <0%> (ø) ⬆️
app/src/renderer/scripts/axiosProxy.js 100% <0%> (ø) ⬆️
... and 90 more

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1837 into develop will increase coverage by 3.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
+ Coverage    94.66%   97.85%   +3.19%     
===========================================
  Files          122      102      -20     
  Lines         2941     2096     -845     
  Branches       119       93      -26     
===========================================
- Hits          2784     2051     -733     
+ Misses         148       37     -111     
+ Partials         9        8       -1
Impacted Files Coverage Δ
...p/src/renderer/components/common/TmModalSearch.vue 73.33% <0%> (-26.67%) ⬇️
...src/renderer/components/common/TmSessionSignIn.vue 75.86% <0%> (-14.47%) ⬇️
app/src/renderer/components/wallet/PageWallet.vue 91.66% <0%> (-8.34%) ⬇️
app/src/renderer/vuex/modules/themes.js 90.9% <0%> (-2.43%) ⬇️
app/src/renderer/vuex/modules/wallet.js 98.3% <0%> (-1.7%) ⬇️
...derer/components/common/TmSessionAccountDelete.vue 92.85% <0%> (-1.59%) ⬇️
.../renderer/components/common/TmConnectedNetwork.vue 89.47% <0%> (-0.53%) ⬇️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/validators.js 100% <0%> (ø) ⬆️
app/src/renderer/scripts/axiosProxy.js 100% <0%> (ø) ⬆️
... and 90 more

@faboweb faboweb merged commit 1d0146d into luniehq:develop Jan 16, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jan 16, 2019

Merged, Thx Corey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants