Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom image for voyager build / AWS deployment #1942

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

mircea-c
Copy link
Contributor

@mircea-c mircea-c commented Feb 9, 2019

Closes #ISSUE

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #1942 into sabau/web/1833-deploy-prerequisites will not change coverage.
The diff coverage is n/a.

@@                         Coverage Diff                          @@
##           sabau/web/1833-deploy-prerequisites    #1942   +/-   ##
====================================================================
  Coverage                                94.91%   94.91%           
====================================================================
  Files                                      119      119           
  Lines                                     2557     2557           
  Branches                                   120      120           
====================================================================
  Hits                                      2427     2427           
  Misses                                     120      120           
  Partials                                    10       10

.circleci/config.yml Outdated Show resolved Hide resolved
sabau
sabau previously approved these changes Feb 9, 2019
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I would just wait to see others opinion on deploying branches, but it works!

@sabau sabau dismissed their stale review February 10, 2019 21:02

I think we should remove the feature deployment

.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mircea-c let's merge!

@sabau sabau merged commit 200f406 into sabau/web/1833-deploy-prerequisites Feb 12, 2019
@sabau sabau deleted the mircea/voyager_deployment branch February 12, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants