Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/2138 fix nbsp #2163

Merged
merged 7 commits into from
Mar 5, 2019
Merged

Fabo/2138 fix nbsp #2163

merged 7 commits into from
Mar 5, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 5, 2019 •
edited by fedekunze
Loading

Closes #2138
Closes #1211

Description:

Thank you! 🚀

For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #2163 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2163   +/-   ##
========================================
  Coverage    95.49%   95.49%           
========================================
  Files          106      106           
  Lines         2265     2265           
  Branches       113      113           
========================================
  Hits          2163     2163           
  Misses          94       94           
  Partials         8        8
Impacted Files Coverage Δ
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.76% <ø> (ø) ⬆️
...rc/renderer/components/common/TmSessionWelcome.vue 100% <ø> (ø) ⬆️
...c/renderer/components/common/TmSessionHardware.vue 100% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #2163 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2163   +/-   ##
========================================
  Coverage    95.52%   95.52%           
========================================
  Files          108      108           
  Lines         2278     2278           
  Branches       115      115           
========================================
  Hits          2176     2176           
  Misses          94       94           
  Partials         8        8
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 98.75% <ø> (ø) ⬆️
...rc/renderer/components/common/TmSessionWelcome.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 98.11% <ø> (ø) ⬆️
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
...c/renderer/components/common/TmSessionHardware.vue 100% <ø> (ø) ⬆️

jbibla
jbibla previously approved these changes Mar 5, 2019
View reviewed changes
@fedekunze
Copy link
Contributor

conflicts bitte

fedekunze
fedekunze approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbibla jbibla merged commit b43ff87 into develop Mar 5, 2019
@jbibla jbibla deleted the fabo/2138-fix-nbsp branch March 5, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibla jbibla jbibla approved these changes

@fedekunze fedekunze fedekunze approved these changes

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non interpreted non breaking space TypeError: Cannot read property 'keybase' of undefined
3 participants
@faboweb @fedekunze @jbibla