Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/2183 fix page network block loading #2187

Merged
merged 8 commits into from
Mar 7, 2019
Merged

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Mar 6, 2019

Closes #2183

Description:

  • show a loading block if there are no blocks loaded yet

screen shot 2019-03-06 at 7 44 47 am

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2187 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2187   +/-   ##
========================================
  Coverage    95.46%   95.46%           
========================================
  Files          108      108           
  Lines         2293     2293           
  Branches       112      112           
========================================
  Hits          2189     2189           
  Misses          94       94           
  Partials        10       10
Impacted Files Coverage Δ
...pp/src/renderer/components/network/PageNetwork.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
...nderer/components/staking/TabStakingParameters.vue 100% <ø> (ø) ⬆️
...c/renderer/components/governance/TabParameters.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/LiValidator.vue 90% <100%> (ø) ⬆️
app/src/renderer/components/network/PageBlock.vue 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2187 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2187   +/-   ##
========================================
  Coverage    95.52%   95.52%           
========================================
  Files          108      108           
  Lines         2278     2278           
  Branches       115      115           
========================================
  Hits          2176     2176           
  Misses          94       94           
  Partials         8        8
Impacted Files Coverage Δ
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/network/PageNetwork.vue 100% <ø> (ø) ⬆️

@fedekunze
Copy link
Contributor

Transactions should start on 0 or have a loader too

@jbibla
Copy link
Collaborator Author

jbibla commented Mar 6, 2019

Transactions should start on 0 or have a loader too

you mean on new blocks as they come in?

@fedekunze
Copy link
Contributor

you mean on new blocks as they come in?

yes, when you're first redirected to the Network page

@jbibla
Copy link
Collaborator Author

jbibla commented Mar 6, 2019

the first thing you'll see is the screenshot above. are you saying when new blocks come in, the transaction count can be delayed?

@faboweb
Copy link
Collaborator

faboweb commented Mar 6, 2019

he means (I think) the transaction count (first row third column) should also either show a loader or a "0"

faboweb
faboweb previously approved these changes Mar 7, 2019
@faboweb faboweb merged commit b71889b into develop Mar 7, 2019
@faboweb faboweb deleted the jordan/2183-block-loader branch March 7, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants