Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2202+2204 fix number #2205

Merged
merged 12 commits into from
Mar 7, 2019
Merged

Fabo/2202+2204 fix number #2205

merged 12 commits into from
Mar 7, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 7, 2019

Closes #2202, #2204

Description:

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 7, 2019

fixed some changes from "CHANGELOG.md" to "PENDING.md"

@faboweb faboweb changed the title Fabo/2202+2204 fix number WIP Fabo/2202+2204 fix number Mar 7, 2019
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #2205 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2205      +/-   ##
===========================================
- Coverage    95.46%   95.44%   -0.03%     
===========================================
  Files          108      108              
  Lines         2293     2281      -12     
  Branches       112      116       +4     
===========================================
- Hits          2189     2177      -12     
  Misses          94       94              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/scripts/num.js 100% <100%> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 97.77% <100%> (ø) ⬆️
...r/components/transactions/TmLiStakeTransaction.vue 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #2205 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2205      +/-   ##
===========================================
- Coverage    95.46%   95.44%   -0.03%     
===========================================
  Files          108      108              
  Lines         2293     2281      -12     
  Branches       112      116       +4     
===========================================
- Hits          2189     2177      -12     
  Misses          94       94              
  Partials        10       10
Impacted Files Coverage Δ
...pp/src/renderer/components/staking/LiValidator.vue 90% <100%> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 97.77% <100%> (ø) ⬆️
...r/components/transactions/TmLiStakeTransaction.vue 100% <100%> (ø) ⬆️
app/src/renderer/scripts/num.js 100% <100%> (ø) ⬆️
...er/components/transactions/TmLiBankTransaction.vue 100% <100%> (ø) ⬆️
...rer/components/transactions/TmLiGovTransaction.vue 100% <100%> (ø) ⬆️

@faboweb faboweb changed the title WIP Fabo/2202+2204 fix number Fabo/2202+2204 fix number Mar 7, 2019
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #2205 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2205      +/-   ##
===========================================
+ Coverage    95.41%   95.44%   +0.02%     
===========================================
  Files          109      108       -1     
  Lines         2291     2281      -10     
  Branches       110      116       +6     
===========================================
- Hits          2186     2177       -9     
- Misses          92       94       +2     
+ Partials        13       10       -3
Impacted Files Coverage Δ
...pp/src/renderer/components/staking/LiValidator.vue 90% <100%> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 97.77% <100%> (+0.1%) ⬆️
...r/components/transactions/TmLiStakeTransaction.vue 100% <100%> (ø)
app/src/renderer/scripts/num.js 100% <100%> (ø) ⬆️
...er/components/transactions/TmLiBankTransaction.vue 100% <100%> (ø)
...rer/components/transactions/TmLiGovTransaction.vue 100% <100%> (ø)
app/src/renderer/vuex/modules/transactions.js 96% <0%> (-4%) ⬇️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
... and 22 more

<span
class="tx-unbonding__time-diff"
>
</template><template v-if="timeDiff">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't love this spacing

jbibla
jbibla previously approved these changes Mar 7, 2019
@faboweb faboweb merged commit f822491 into develop Mar 7, 2019
@faboweb faboweb deleted the fabo/2202+2204-fix-number branch March 7, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very small amounts are displayed wrong
3 participants