Jordan/2188 page network bug #2214

jbibla · 2019-03-07T22:49:10Z

Closes #2188

Description:

using TmPage loading, loaded, dataset props
updated Connecting Msg copy
added blocks.loaded to module

Thank you! 🚀

For contributor:

Added entries in PENDING.md with issue # and GitHub username
Reviewed Files changed in the github PR explorer
Attach screenshots of the UI components on the PR description (if applicable)
Scope of work approved for big PRs

For reviewer:

Manually tested the changes on the UI

jbibla · 2019-03-07T22:49:57Z

app/src/renderer/components/common/TmPage.vue

@@ -87,7 +87,7 @@ export default {
      default: undefined
    },
    dataset: {
-      type: Array,
+      type: [Array, Object],


i know we agreed to not permit this. however, this might be time for an exception or please share a suggestion for how to avoid this.

this needs to be an array or more then this needs to be refactored. see line 28

proposal: change to "dataAvailable" and make it a boolean. checks are then performed on each page on the individual dataset

Also cheaper to pass

ok makes sense. do you guys think this should be done in this PR and not separately?

let's do it in here. the change needs to happen in only 3 places and we don't pile up more dept.

in only 3 places

yeah. one line 😝

jbibla · 2019-03-07T22:51:29Z

app/src/renderer/components/network/PageNetwork.vue

+    :loading="blocks.loading"
+    :loaded="blocks.loaded"
+    :error="blocks.error"
+    :dataset="lastHeader"


page network is a bit strange because it doesn't need the "items" (dataset) to load. it just needs a connection to render the top part of the page. the blocks are the second "dataset". lastHeader and connection don't have loading, loaded, or error states...

reveals room for a refactor - but this might be sufficient for now.

I think we have in the store the list of blocks, but I like more @faboweb idea of booleanize

codecov · 2019-03-07T22:51:44Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@f822491). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff             @@
##             develop    #2214   +/-   ##
==========================================
  Coverage           ?   95.34%           
==========================================
  Files              ?      108           
  Lines              ?     2279           
  Branches           ?      114           
==========================================
  Hits               ?     2173           
  Misses             ?       93           
  Partials           ?       13

Impacted Files	Coverage Δ
...pp/src/renderer/components/network/PageNetwork.vue	`100% <ø> (ø)`
app/src/renderer/components/common/TmPage.vue	`100% <ø> (ø)`
app/src/renderer/vuex/modules/blocks.js	`98.3% <50%> (ø)`

codecov · 2019-03-07T22:51:44Z

Codecov Report

Merging #2214 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2214      +/-   ##
===========================================
- Coverage    96.63%   96.62%   -0.01%     
===========================================
  Files          109      108       -1     
  Lines         2316     2314       -2     
  Branches       116      116              
===========================================
- Hits          2238     2236       -2     
  Misses          65       65              
  Partials        13       13

Impacted Files	Coverage Δ
app/src/renderer/components/common/TmPage.vue	`100% <ø> (ø)`	⬆️
...pp/src/renderer/components/network/PageNetwork.vue	`100% <ø> (ø)`	⬆️
.../renderer/components/governance/PageGovernance.vue	`100% <ø> (ø)`	⬆️
app/src/renderer/components/wallet/PageWallet.vue	`96.29% <100%> (ø)`	⬆️
...rc/renderer/components/wallet/PageTransactions.vue	`100% <100%> (ø)`	⬆️
...ponents/transactions/LiDistributionTransaction.vue	`85.71% <0%> (ø)`	⬆️

sabau · 2019-03-11T17:39:49Z

I think this should be merged right after TmPage and PageNetwork stuff is done, all good and and is a bug fix

…mos/voyager into jordan/2188-page-network-bug

PENDING.md

sabau · 2019-03-12T17:48:45Z

app/src/renderer/components/governance/PageGovernance.vue

-    class="governance"
-    data-title="Governance"
-  >
+  <tm-page :tabs="tabs" class="governance" data-title="Governance">


Shouldn't we cover the case when we have no proposals with the new Boolean dataEmpty?

yes, we do. but currently the logic for this is in TabProposals, not PageGov. Our page structure is a bit funny. But this is not needed here, now.

#2237 #2060

sabau

That's true TmPage with tabs hide some logic

sabau

let's fix the network

jbibla added 2 commits March 7, 2019 17:41

fixed tm-page page-network loading inconsistencies

e0f17f7

fixed snaperoos

e3fbeb1

jbibla requested review from faboweb, fedekunze and sabau as code owners March 7, 2019 22:49

jbibla commented Mar 7, 2019

View reviewed changes

no message

1d1dbb2

jbibla and others added 5 commits March 11, 2019 21:56

added data empty with one prop type

6ba1e20

Merge branch 'develop' into jordan/2188-page-network-bug

1920ab5

loaded is not needed

6071f40

Merge branch 'jordan/2188-page-network-bug' of https://github.com/cos…

b6401cf

…mos/voyager into jordan/2188-page-network-bug

fixed data-empty being reverse

c7347c6

faboweb previously approved these changes Mar 12, 2019

View reviewed changes

Merge branch 'develop' into jordan/2188-page-network-bug

9340bae

jbibla dismissed faboweb’s stale review via 9340bae March 12, 2019 17:18

faboweb previously approved these changes Mar 12, 2019

View reviewed changes

fedekunze reviewed Mar 12, 2019

View reviewed changes

PENDING.md Outdated Show resolved Hide resolved

Update PENDING.md

89b679a

faboweb dismissed their stale review via 89b679a March 12, 2019 17:53

Merge branch 'develop' into jordan/2188-page-network-bug

03d6f5d

sabau reviewed Mar 12, 2019

View reviewed changes

Merge branch 'develop' into jordan/2188-page-network-bug

04b83bb

faboweb previously approved these changes Mar 13, 2019

View reviewed changes

sabau previously approved these changes Mar 13, 2019

View reviewed changes

Merge branch 'develop' into jordan/2188-page-network-bug

bf7d24f

sabau dismissed their stale review via bf7d24f March 13, 2019 11:06

sabau dismissed faboweb’s stale review via bf7d24f March 13, 2019 11:06

sabau previously approved these changes Mar 13, 2019

View reviewed changes

Merge branch 'develop' into jordan/2188-page-network-bug

101decf

faboweb dismissed sabau’s stale review via 101decf March 13, 2019 11:11

faboweb merged commit f05bf1a into develop Mar 13, 2019

faboweb deleted the jordan/2188-page-network-bug branch March 13, 2019 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jordan/2188 page network bug #2214

Jordan/2188 page network bug #2214

jbibla commented Mar 7, 2019

jbibla Mar 7, 2019

faboweb Mar 8, 2019

faboweb Mar 8, 2019

sabau Mar 8, 2019

jbibla Mar 8, 2019

faboweb Mar 9, 2019

jbibla Mar 11, 2019

jbibla Mar 7, 2019

sabau Mar 8, 2019

jbibla Mar 8, 2019

codecov bot commented Mar 7, 2019

codecov bot commented Mar 7, 2019 •

edited

Loading

sabau commented Mar 11, 2019

sabau Mar 12, 2019

jbibla Mar 12, 2019 •

edited

Loading

sabau left a comment

sabau left a comment

Jordan/2188 page network bug #2214

Jordan/2188 page network bug #2214

Conversation

jbibla commented Mar 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 7, 2019

Codecov Report

codecov bot commented Mar 7, 2019 • edited Loading

Codecov Report

sabau commented Mar 11, 2019

Choose a reason for hiding this comment

jbibla Mar 12, 2019 • edited Loading

Choose a reason for hiding this comment

sabau left a comment

Choose a reason for hiding this comment

sabau left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 7, 2019 •

edited

Loading

jbibla Mar 12, 2019 •

edited

Loading