Multiple accounts #224
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,5 +25,5 @@ export default { | |
| @require '~variables' | ||
|
|
||
| .ni-field.ni-field-seed | ||
| height 6rem | ||
| </style> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| export default ({ commit, node }) => { | ||
| const emptyNomination = { | ||
| keybase: '', | ||
|
|
@@ -20,35 +18,38 @@ export default ({ commit, node }) => { | |
| delegation: [], | ||
| pubkey: '', | ||
| privkey: null, | ||
| signedIn: false, | ||
| accounts: [] | ||
| } | ||
|
|
||
| const state = JSON.parse(JSON.stringify(emptyUser)) | ||
|
|
||
| const mutations = { | ||
| activateDelegation (state) { | ||
| state.delegationActive = true | ||
| }, | ||
| setAccounts (state, accounts) { | ||
| state.accounts = accounts | ||
| } | ||
| } | ||
|
|
||
| const actions = { | ||
| async showInitialScreen ({ dispatch }) { | ||
| await dispatch('loadAccounts') | ||
| let exists = state.accounts.length > 0 | ||
| let screen = exists ? 'sign-in' : 'welcome' | ||
| commit('setModalSessionState', screen) | ||
| commit('setModalSession', true) | ||
| }, | ||
| async loadAccounts ({ commit }) { | ||
| try { | ||
| let keys = await node.listKeys() | ||
| commit('setAccounts', keys.map((key) => key.name)) | ||
| } catch (err) { | ||
| commit('notifyError', { title: `Couldn't read keys`, body: err.message }) | ||
| } | ||
| }, | ||
| async testLogin (state, { password, account }) { | ||
| try { | ||
| return await node.updateKey(account, { | ||
| name: account, | ||
|
|
@@ -62,41 +63,42 @@ export default ({ commit, node }) => { | |
| // to create a temporary seed phrase, we create a junk account with name 'trunk' for now | ||
| async createSeed ({ commit }) { | ||
| let JUNK_ACCOUNT_NAME = 'trunk' | ||
| let TRUNK_PASSWORD = '1234567890' | ||
|
There was a problem hiding this comment. We need to get rid of this. A malicious user could access the last generated trunk account with the standard password. There was a problem hiding this comment. Prerequesit: cosmos/cosmos-sdk#301 There was a problem hiding this comment. do you mean in this PR or an another PR? this is not new — this is currently how it works... There was a problem hiding this comment. Just a note. I commented on that, because I implemented it like that and wanted to share the thought. |
||
| try { | ||
| // cleanup an existing junk account | ||
| let keys = await node.listKeys() | ||
| if (keys.find(key => key.name === JUNK_ACCOUNT_NAME)) { | ||
| await node.deleteKey(JUNK_ACCOUNT_NAME, { | ||
| password: TRUNK_PASSWORD, | ||
| name: JUNK_ACCOUNT_NAME | ||
| }) | ||
| } | ||
|
|
||
| // generate seedPhrase with junk account | ||
| let temporaryKey = await node.generateKey({ name: JUNK_ACCOUNT_NAME, password: TRUNK_PASSWORD }) | ||
| return temporaryKey.seed_phrase | ||
| } catch (err) { | ||
| commit('notifyError', { title: `Couldn't create a seed`, body: err.message }) | ||
| } | ||
| }, | ||
| async createKey ({ commit, dispatch }, { seedPhrase, password, name }) { | ||
| try { | ||
| let {key} = await node.recoverKey({ name, password, seed_phrase: seedPhrase }) | ||
| dispatch('initializeWallet', key) | ||
| return key | ||
| } catch (err) { | ||
| commit('notifyError', { title: `Couldn't create a key`, body: err.message }) | ||
| } | ||
| }, | ||
| async deleteKey ({ commit, dispatch }, { password, name }) { | ||
| try { | ||
| await node.deleteKey(name, { name, password }) | ||
| return true | ||
| } catch (err) { | ||
| commit('notifyError', { title: `Couldn't delete account ${name}`, body: err.message }) | ||
| } | ||
| }, | ||
| async signIn ({ state, dispatch }, { password, account }) { | ||
| state.password = password | ||
| state.account = account | ||
| state.signedIn = true | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use allDenomBalances.length?