Fabo/release PR now adds PENDING.md to CHANGELOG.md #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2242 +/- ##
==========================================
+ Coverage 95.43% 96.3% +0.86%
==========================================
Files 109 109
Lines 2300 2300
Branches 116 116
==========================================
+ Hits 2195 2215 +20
+ Misses 92 72 -20
Partials 13 13
|
|
Nice, we should also changer |
sabau
reviewed
Mar 12, 2019
tasks/createReleasePR.js
Outdated
| @@ -60,15 +60,16 @@ if (require.main === module) { | |||
| cli({}, async () => { | |||
| console.log(`Making release...`) | |||
| const changeLog = fs.readFileSync(__dirname + `/../CHANGELOG.md`, `utf8`) | |||
| const pending = fs.readFileSync(__dirname + `/../PENDING.md`, `utf8`) | |||
There was a problem hiding this comment.
just nice to have for compatibility:
- we should create paths using the OS agnostic path.join(__dirname, '..', 'PENDING.md')
added 2 commits
March 12, 2019 12:03
faboweb
force-pushed
the
fabo/pending-to-pr
branch
from
33a4480
to
4b2165c
Compare
|
done @sabau |
jbibla
reviewed
Mar 12, 2019
CHANGELOG.md
Outdated
| @@ -7,6 +7,32 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [1.0.0-beta.22] - 2019-03-12 | |||
There was a problem hiding this comment.
That's from the tests. I will fix it.
sabau
previously approved these changes
Mar 12, 2019
|
does this also cleans up (deletes the content from) the PENDING file afterwards? |
|
fedekunze
approved these changes
Mar 12, 2019
jbibla
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: